Skip to content

use PDI to end the isolated scope for RLI #141345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jan 30, 2024
Merged

use PDI to end the isolated scope for RLI #141345

auto-submit merged 2 commits into from
Jan 30, 2024

Conversation

@kseino
Copy link
Contributor

@kseino kseino commented Jan 11, 2024 •
edited
Loading

will fix #141344

https://unicode.org/reports/tr9/#Explicit_Directional_Isolates
https://api.flutter.dev/flutter/foundation/Unicode/RLI-constant.html

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 11, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 11, 2024
@kseino
Copy link
Contributor Author

kseino commented Jan 11, 2024

i need [an exemption] but i can not find a way to join #hackers channel...

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer
Copy link
Member

goderbauer commented Jan 16, 2024

@kseino Thanks for your contribution. This will need a test, though, to make sure that we never accidentally revert the change. Can you please add one?

@kseino
Copy link
Contributor Author

kseino commented Jan 17, 2024 •
edited
Loading

@kseino Thanks for your contribution. This will need a test, though, to make sure that we never accidentally revert the change. Can you please add one?

@goderbauer hello, added a test for this 👍

@HansMuller HansMuller requested a review from hannah-hyj January 19, 2024 22:45
hannah-hyj
hannah-hyj approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also thank you for providing the info links!

justinmc
justinmc approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit auto-submit bot merged commit 9ed650a into flutter:master Jan 30, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2024
@engine-flutter-autoroll
9ed650a use PDI to end the isolated scope for RLI (flutter/flutter#14…
406367e 
…1345)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 1, 2024
@engine-flutter-autoroll
Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (#6026)
aee1980 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@75a2e5b...c65ab4d

2024-01-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583)
2024-01-31 ian@hixie.ch Add `DropdownMenu.focusNode` (flutter/flutter#142516)
2024-01-31 fluttergithubbot@gmail.com Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042)
2024-01-31 fluttergithubbot@gmail.com Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039)
2024-01-31 fluttergithubbot@gmail.com Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040)
2024-01-31 fluttergithubbot@gmail.com Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041)
2024-01-31 fluttergithubbot@gmail.com Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647)
2024-01-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569)
2024-01-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566)
2024-01-31 davidmartos96@gmail.com M3 - Fix Chip icon and label colors (flutter/flutter#140573)
2024-01-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564)
2024-01-30 ian@hixie.ch Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611)
2024-01-30 kouhei.seino@woven-planet.global use PDI to end the isolated scope for RLI (flutter/flutter#141345)
2024-01-30 ian@hixie.ch Style correctness improvements for toStrings and related fixes (flutter/flutter#142485)
2024-01-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553)
2024-01-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551)
2024-01-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548)
2024-01-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543)
2024-01-30 rmolivares@renzo-olivares.dev Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476)
2024-01-30 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675)
2024-01-30 jonahwilliams@google.com Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
9ed650a use PDI to end the isolated scope for RLI (flutter/flutter#14…
01a4051 
…1345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Directional Formatting Characters in SemanticsDebugger

4 participants

@kseino @goderbauer @justinmc @hannah-hyj