Fix SegmentedButton states update logic
#140772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
requested changes
Jan 3, 2024
Member
TahaTesser
left a comment
There was a problem hiding this comment.
Thanks for contributing! I've applied some updates to your code.
Contributor
Author
|
@TahaTesser Thanks for the changes you suggested, I appreciate it. All resolved |
TahaTesser
approved these changes
Jan 3, 2024
SegmentedButton states update logic
TahaTesser
requested changes
Jan 4, 2024
Member
|
We will a second review from Hans before we can land this. |
HansMuller
reviewed
Jan 4, 2024
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Looks good, just some indentation issues. I'll merge those.
| controller.value = <MaterialState>{ | ||
| if (segmentSelected) MaterialState.selected, | ||
| }; | ||
| controller.update(MaterialState.selected, segmentSelected); |
Fixed some trivial indentation problems
Contributor
Author
|
Thanks, @HansMuller and @TahaTesser for your efforts. I saw it was merged and you guys made my day |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 5, 2024
tarrinneal
added a commit
to flutter/packages
that referenced
this pull request
Jan 5, 2024
Manual roll Flutter from 11def8e to cc40425 (118 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@11def8e...cc40425 2024-01-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990) 2024-01-04 yjbanov@google.com [web] Fix and unskip a few more CanvasKit tests (flutter/flutter#140821) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986) 2024-01-04 danny@tuppeny.com Pin package:vm_service (flutter/flutter#140972) 2024-01-04 36861262+QuncCccccc@users.noreply.github.com Add scrollbar for menus (flutter/flutter#140941) 2024-01-04 christopherfujino@gmail.com manual pub roll to pick up dds fixes (flutter/flutter#140979) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980) 2024-01-04 polinach@google.com Temporarily remove env variable for leak tracking bots. (flutter/flutter#140978) 2024-01-04 chillers@google.com Add Flutter CI status to README (flutter/flutter#140513) 2024-01-04 polinach@google.com Reland "integrate testWidgets with leak tracking" (#140521) (flutter/flutter#140928) 2024-01-04 15619084+vashworth@users.noreply.github.com Run half of iOS devicelab tests with Xcode 15 (flutter/flutter#140927) 2024-01-04 39755477+sharabiddin@users.noreply.github.com Fix `SegmentedButton` states update logic (flutter/flutter#140772) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973) 2024-01-04 pateltirth454@gmail.com [Fix] Consistency in ButtonStyleButton related Tests (flutter/flutter#140610) 2024-01-04 engine-flutter-autoroll@skia.org Roll Packages from bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967) 2024-01-04 stuartmorgan@google.com Fix local engine use in macOS plugins (flutter/flutter#140222) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936) 2024-01-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929) 2024-01-03 magder@google.com Remove deprecated bitcode stripping from tooling (flutter/flutter#140903) 2024-01-03 54558023+keyonghan@users.noreply.github.com Add Windows leak tracking targets (flutter/flutter#140423) 2024-01-03 xilaizhang@google.com [github actions] refactor and fix cherry pick actions (flutter/flutter#140499) 2024-01-03 magder@google.com Migrate Xcode projects last version checks to Xcode 15.1 (flutter/flutter#140256) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920) 2024-01-03 goderbauer@google.com fix typo and reflow (flutter/flutter#140925) 2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Re-land integrate testWidgets with leak tracking." (flutter/flutter#140926) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915) 2024-01-03 ybz975218925@gmail.com Changes the regular cursor to a floating cursor when a long press occurs. (flutter/flutter#138479) 2024-01-03 65075121+AcarFurkan@users.noreply.github.com Add `SegmentedButton.styleFrom` (flutter/flutter#137542) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910) 2024-01-03 polinach@google.com Re-land integrate testWidgets with leak tracking. (flutter/flutter#140521) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905) 2024-01-03 jonahwilliams@google.com [flutter_tools] add support for --enable-impeller to test device. (flutter/flutter#140899) 2024-01-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897) 2024-01-03 233583+mossmana@users.noreply.github.com Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808) 2024-01-03 lsaudon@gmail.com Add Lucas Saudon to AUTHORS (flutter/flutter#139965) 2024-01-03 21270878+elliette@users.noreply.github.com Link to wiki page about updating dependencies in each `pubspec.yaml` file (flutter/flutter#140826) 2024-01-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro native_assets_android to be unflaky (flutter/flutter#140866) ... --------- Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #140746
Desc: Style state update logic fix on SegmentedButton
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].