Skip to content

Conversation

@elliette
Copy link
Member

@elliette elliette commented Dec 28, 2023

Update DWDS version on Flutter stable to a hotfix release to resolve dart-lang/webdev#2297

See dart-lang/webdev#2319

@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master December 28, 2023 23:16
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop f: focus Focus traversal, gaining or losing focus f: integration_test The flutter/packages/integration_test plugin labels Dec 28, 2023
@elliette elliette changed the base branch from master to stable December 28, 2023 23:17
@itsjustkevin
Copy link
Contributor

Shouldn't the pubspec checksum be updated when changing versions? We might want to hold off on these until next week.

@christopherfujino
Copy link
Contributor

the merge target should be a release-candidate branch, also, not stable. I'm guessing the branch should be: flutter-3.16-candidate.0? Per https://github.com/flutter/flutter/blob/stable/bin/internal/release-candidate-branch.version

@elliette elliette changed the base branch from stable to flutter-3.16-candidate.0 January 2, 2024 17:39
@elliette
Copy link
Member Author

elliette commented Jan 2, 2024

Shouldn't the pubspec checksum be updated when changing versions? We might want to hold off on these until next week.

How do I update the pubspec checksum?

@christopherfujino
Copy link
Contributor

Shouldn't the pubspec checksum be updated when changing versions? We might want to hold off on these until next week.

How do I update the pubspec checksum?

Probably the best way to do so for release cherry picks would be to use:

flutter update-packages --cherry-pick-package=dwds --cherry-pick-version='21.0.0+1'

This will ensure ONLY dwds is changed, and that the checksum is written.

@elliette
Copy link
Member Author

elliette commented Jan 2, 2024

Thanks! Updated the checksum

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot merged commit 5a21b62 into flutter:flutter-3.16-candidate.0 Jan 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: focus Focus traversal, gaining or losing focus f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting DWDS error when deubg on web

4 participants