Skip to content

Change cast in json parsing #137708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 6, 2023
Merged

Change cast in json parsing #137708

auto-submit merged 1 commit into from
Nov 6, 2023

Conversation

@iinozemtsev
Copy link
Contributor

@iinozemtsev iinozemtsev commented Nov 1, 2023

jsonDecode decodes lists as List<Object?>, so the cast to List<Object> fails at runtime in sound null safety mode.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 1, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 1, 2023
chingjun
chingjun approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@chingjun chingjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 2, 2023

auto label is removed for flutter/flutter/137708, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
christopherfujino
christopherfujino approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this will need a unit test in this file: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/proxied_devices/file_transfer_test.dart

@iinozemtsev
Copy link
Contributor Author

iinozemtsev commented Nov 3, 2023

LGTM. this will need a unit test

Done, please take a look. Made sure that the test fails without the change:

00:00 +14 -1: BlockHashes json conversion works normally [E]

  type 'List<dynamic>' is not a subtype of type 'List<Object>' in type cast

  package:flutter_tools/src/proxied_devices/file_transfer.dart 54:25  BlockHashes.fromJson
  test/general.shard/proxied_devices/file_transfer_test.dart 209:26   main.<fn>.<fn>
  test/src/common.dart 183:18                                         test.<fn>
  package:test_api/src/backend/declarer.dart 215:19                   Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7                    Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9                     Invoker._waitForOutstandingCallbacks.<fn>


00:00 +14 -1: Some tests failed.

christopherfujino
christopherfujino approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this fix!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 3, 2023

auto label is removed for flutter/flutter/137708, due to - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023
@iinozemtsev
Change cast in json parsing
07e0b5f 
jsonDecode decodes lists as `List<Object?>`, so the cast to
`List<Object>` fails at runtime in sound null safety mode.
@iinozemtsev
Copy link
Contributor Author

iinozemtsev commented Nov 6, 2023

Could you please re-add autosubmit label? The checks are passing now

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2023
@auto-submit auto-submit bot merged commit defa4bc into flutter:master Nov 6, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
defa4bc Change cast in json parsing (flutter/flutter#137708)
285028b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
defa4bc Change cast in json parsing (flutter/flutter#137708)
da9b3d9
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
Roll Flutter from 29b2516 to f5a9835 (101 revisions) (#5341)
be18d28 
Roll Flutter from 29b2516 to f5a9835 (101 revisions)

flutter/flutter@29b2516...f5a9835

2023-11-06 gspencergoog@users.noreply.github.com Check sample links for malformed links (flutter/flutter#137807)
2023-11-06 iinozemtsev@google.com Change cast in json parsing (flutter/flutter#137708)
2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948)
2023-11-06 engine-flutter-autoroll@skia.org Roll Packages from cccf5d2 to 49eac1f (2 revisions) (flutter/flutter#137943)
2023-11-06 leroux_bruno@yahoo.fr Update BottomNavigationBar tests for M3 (flutter/flutter#136624)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935)
2023-11-06 tessertaha@gmail.com Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933)
2023-11-06 andrewrkolos@gmail.com Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887)
2023-11-04 sokolovskyi.konstantin@gmail.com HeroController should dispatch creation and disposal events. (flutter/flutter#137835)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877)
2023-11-03 thesonerik@gmail.com InheritedElement.removeDependent() (flutter/flutter#129210)
2023-11-03 goderbauer@google.com Remove unused generic type from BottomSheet (flutter/flutter#137791)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872)
2023-11-03 dacoharkes@google.com Pin dart-lang/native dependencies (flutter/flutter#137601)
2023-11-03 chris@bracken.jp Send caret rect to embedder on selection update (flutter/flutter#137863)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871)
2023-11-03 cbobbe@zulip.com Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861)
2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865)
2023-11-03 sokolovskyi.konstantin@gmail.com InkFeature should dispatch creation and disposal events. (flutter/flutter#137793)
2023-11-03 sokolovskyi.konstantin@gmail.com AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857)
2023-11-03 hans.muller@gmail.com Updated the nested navigation NavigationBar example (flutter/flutter#137788)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847)
2023-11-03 jonahwilliams@google.com Roll flutter gallery version forward. (flutter/flutter#137846)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845)
2023-11-03 engine-flutter-autoroll@skia.org Roll Packages from 33c2b4e to cccf5d2 (6 revisions) (flutter/flutter#137841)
2023-11-03 matej.knopp@gmail.com [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874)
2023-11-03 41873024+droidbg@users.noreply.github.com [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170)
2023-11-03 polinach@google.com Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
defa4bc Change cast in json parsing (flutter/flutter#137708)
18b51b5
dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
@engine-flutter-autoroll
Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) (#5341)
186c4e0 
Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions)

flutter/flutter@29b2516...f5a9835

2023-11-06 gspencergoog@users.noreply.github.com Check sample links for malformed links (flutter/flutter#137807)
2023-11-06 iinozemtsev@google.com Change cast in json parsing (flutter/flutter#137708)
2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948)
2023-11-06 engine-flutter-autoroll@skia.org Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (flutter/flutter#137943)
2023-11-06 leroux_bruno@yahoo.fr Update BottomNavigationBar tests for M3 (flutter/flutter#136624)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935)
2023-11-06 tessertaha@gmail.com Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933)
2023-11-06 andrewrkolos@gmail.com Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921)
2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912)
2023-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887)
2023-11-04 sokolovskyi.konstantin@gmail.com HeroController should dispatch creation and disposal events. (flutter/flutter#137835)
2023-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877)
2023-11-03 thesonerik@gmail.com InheritedElement.removeDependent() (flutter/flutter#129210)
2023-11-03 goderbauer@google.com Remove unused generic type from BottomSheet (flutter/flutter#137791)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872)
2023-11-03 dacoharkes@google.com Pin dart-lang/native dependencies (flutter/flutter#137601)
2023-11-03 chris@bracken.jp Send caret rect to embedder on selection update (flutter/flutter#137863)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871)
2023-11-03 cbobbe@zulip.com Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861)
2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865)
2023-11-03 sokolovskyi.konstantin@gmail.com InkFeature should dispatch creation and disposal events. (flutter/flutter#137793)
2023-11-03 sokolovskyi.konstantin@gmail.com AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857)
2023-11-03 hans.muller@gmail.com Updated the nested navigation NavigationBar example (flutter/flutter#137788)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847)
2023-11-03 jonahwilliams@google.com Roll flutter gallery version forward. (flutter/flutter#137846)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845)
2023-11-03 engine-flutter-autoroll@skia.org Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) (flutter/flutter#137841)
2023-11-03 matej.knopp@gmail.com [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874)
2023-11-03 41873024+droidbg@users.noreply.github.com [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170)
2023-11-03 polinach@google.com Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806)
2023-11-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingjun chingjun chingjun approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iinozemtsev @chingjun @christopherfujino