Skip to content

reset state of CustomSemanticsAction before running tests #137697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Nov 1, 2023
Merged

reset state of CustomSemanticsAction before running tests #137697

auto-submit merged 2 commits into from
Nov 1, 2023

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Nov 1, 2023 •
edited
Loading

Fixes #137696

This will get the tree green again.

The problem is that CustomSemanticsAction has static state in it, and todays test seed order makes things unhappy.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 1, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Nov 1, 2023
@zanderso zanderso mentioned this pull request Nov 1, 2023
Closed
@github-actions github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Nov 1, 2023
chunhtai
chunhtai approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented Nov 1, 2023

With this in place can we undo the shuffle skip added in https://github.com/flutter/flutter/pull/137698/files?

@dnfield
Copy link
Contributor Author

dnfield commented Nov 1, 2023

With this in place can we undo the shuffle skip added in https://github.com/flutter/flutter/pull/137698/files?

Yes

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2023
@dnfield dnfield mentioned this pull request Nov 1, 2023
Merged
@auto-submit auto-submit bot merged commit d843863 into flutter:master Nov 1, 2023
@dnfield dnfield deleted the isolates_test branch November 1, 2023 20:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
ee67333 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
9f7713b 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
3d53fc0 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
8f3a44d 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
d7f13ef 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
4ba5e98 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
c4a84e7 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
d339c89 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
8cffe34 
…utter/flutter#137697)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
820d601 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
60d7735 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
8eb5f07 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
5e87efc 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
8db07d5 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
281164e 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
81ffe85 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
6ac16e1 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
e5b1b80 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
54858d3 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
90bd6c1 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
dd54b91 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
7a2673c 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
503b5be 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
822d7cc 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
f2f148e 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
274e414 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
76fa7a1 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
286ff79 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
e636d59 
…utter/flutter#137697)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
b9326a2 
…utter/flutter#137697)
goderbauer pushed a commit that referenced this pull request Nov 7, 2023
@dnfield
Revert "Add no-shuffle to reorderable_list_test.dart" (#137715)
e724689 
Reverts #137698

Not needed after #137697

Must not land until after that one
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
d843863 reset state of CustomSemanticsAction before running tests (fl…
8d5b105 
…utter/flutter#137697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove or reset the static counter in CustomSemanticsActions

3 participants

@dnfield @goderbauer @chunhtai