-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Roll Flutter engine incl. new Skia. #13696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a roll of the Engine up to the last version before a Dart roll. Rolls Engine to 5bcbd1c and Skia to ef0384835757df463f5157145650a60ba8b14a63.
mravn-google
approved these changes
Dec 20, 2017
Contributor
mravn-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
This had a really bad impact on |
This was referenced Dec 21, 2017
Contributor
Author
|
I'm on vacation starting today. This regression is probably Skia related
since there was no new Dart in this change (that was the next change).
Skia roll into Engine was by brianosman, now on CC.
…On 21 December 2017 at 19:52, Ian Hickson ***@***.***> wrote:
This had a really bad impact on flutter_gallery__transition_perf
worst_frame_rasterizer_time_millis, more than doubling it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13696 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIIQJ_v3UMiqdo-hDK7bV9OgZmUXZCq5ks5tCqjRgaJpZM4RISqt>
.
--
Erik Corry
Google Denmark ApS
Frederiksborggade 20B, 1 sal
1360 København K
Denmark
CVR nr. 28 86 69 84
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Nov 11, 2019
git@github.com:flutter/engine.git/compare/31cd2dfca22a...eec36a8 git log 31cd2df..eec36a8 --no-merges --oneline 2019-11-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771) 2019-11-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770) 2019-11-09 ychris@google.com Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759) 2019-11-09 matthew-carroll@users.noreply.github.com Point old plugin registry accessors to new embedding plugin accessors. (#44225) (flutter/engine#13739) 2019-11-09 fmil@google.com Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721) 2019-11-09 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a roll of the Engine up to the last version before a Dart
roll. Rolls Engine to 5bcbd1c
and Skia to ef0384835757df463f5157145650a60ba8b14a63.