Reverts "Use Layer.toImage for golden tests on CanvasKit" #136860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 747128f.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
approved these changes
Oct 19, 2023
Member
|
This was consistently failing in postsubmit as in https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_canvaskit_tests_6/11039/overview |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 19, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 19, 2023
flutter/flutter@189196d...c2bd2c1 2023-10-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes ability to call nextFocus() on a node to focus its descendant" (flutter/flutter#136894) 2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from d0d7b4d61265 to 28cb2508b8e0 (1 revision) (flutter/flutter#136878) 2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d51b64e9440 to d0d7b4d61265 (13 revisions) (flutter/flutter#136872) 2023-10-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add code for updating `focusedChild` when removing grandchildren from scope" (flutter/flutter#136862) 2023-10-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use Layer.toImage for golden tests on CanvasKit" (flutter/flutter#136860) 2023-10-18 goderbauer@google.com Bump flutter_lints to 3.0 (flutter/flutter#136841) 2023-10-18 gspencergoog@users.noreply.github.com Add code for updating `focusedChild` when removing grandchildren from scope (flutter/flutter#136771) 2023-10-18 1961493+harryterkelsen@users.noreply.github.com Use Layer.toImage for golden tests on CanvasKit (flutter/flutter#135249) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) (flutter/flutter#136846) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) (flutter/flutter#136844) 2023-10-18 srawlins@google.com Null-assert the value given to a Completer expecting a non-null value (flutter/flutter#136776) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.