Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. #136780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… put code that should occur on application shutdown. This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
2 tasks
Contributor
Author
|
It looks like there is still a fix for the dispose method required, but this is possibly still useful for developers who need to do something when the application stops. Dispose should be used for cleaning up objects, and shutdown for any more complex behaviour. |
cbracken
approved these changes
Oct 18, 2023
Member
There was a problem hiding this comment.
lgtm. Thanks @robert-ancell.
I bet we could write a migrator for this that can retroactively apply this to existing projects. I'm not sure if we have existing migrations for Linux, but I'll file an issue for this and paste a link as a comment on this patch. That should probably be pretty low priority since this is really just a nice hint/convenience for developers and not a necessary change.
I think the main thing we'd get out of it is some stub code for any additional Linux project migrations we want to do down the road. If we already have such code, then it may not be worth doing at all.
Does it sound reasonable that if the migration found an existing assignment to G_APPLICATION_CLASS(klass)->shutdown that we'd do nothing, but otherwise, add the above static func, and set that handler?
Member
|
Filed #136783 as a low priority tracking issue for a migration, for convenience. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 18, 2023
…where to put code that should occur on application shutdown. (flutter/flutter#136780)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 18, 2023
…where to put code that should occur on application shutdown. (flutter/flutter#136780)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 18, 2023
…where to put code that should occur on application shutdown. (flutter/flutter#136780)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 19, 2023
Manual roll Flutter from 6eea6e2 to 189196d (44 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@6eea6e2...189196d 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (flutter/flutter#136834) 2023-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136839) 2023-10-18 gspencergoog@users.noreply.github.com Convert menus to use OverlayPortal (flutter/flutter#130534) 2023-10-18 15619084+vashworth@users.noreply.github.com [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136751) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (flutter/flutter#136832) 2023-10-18 47866232+chunhtai@users.noreply.github.com Fixes ability to call nextFocus() on a node to focus its descendant (flutter/flutter#136773) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (flutter/flutter#136829) 2023-10-18 robert.ancell@canonical.com Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (flutter/flutter#136780) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (flutter/flutter#136818) 2023-10-18 tessertaha@gmail.com Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (flutter/flutter#136720) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (flutter/flutter#136817) 2023-10-18 838@mail.com [Feat] Stroke color for Slider value indicator (flutter/flutter#135986) 2023-10-18 76067278+aakash-pamnani@users.noreply.github.com Fixed : Empty Rows shown at last page in Paginated data table (flutter/flutter#132646) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (flutter/flutter#136814) 2023-10-18 engine-flutter-autoroll@skia.org Roll Packages from d439062 to 14aa69e (1 revision) (flutter/flutter#136813) 2023-10-18 dacoharkes@google.com Don't build native assets in `flutter build bundle` (flutter/flutter#136641) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (flutter/flutter#136795) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (flutter/flutter#136792) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (flutter/flutter#136789) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (flutter/flutter#136785) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (flutter/flutter#136781) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (flutter/flutter#136777) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (flutter/flutter#136774) 2023-10-18 christopherfujino@gmail.com Flutter preview device (flutter/flutter#135639) 2023-10-18 gildasiogx@gmail.com Add findChildIndexCallback examples (flutter/flutter#133469) 2023-10-18 109253501+pdblasi-google@users.noreply.github.com Adds API for performing semantics actions in tests (flutter/flutter#132598) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (flutter/flutter#136772) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (flutter/flutter#136768) 2023-10-17 andrewrkolos@gmail.com clean up `--dart-define-from-file` option tests (flutter/flutter#135980) 2023-10-17 sokolovskyi.konstantin@gmail.com GoldenFileComparators should dispose created Image objects. (flutter/flutter#136716) 2023-10-17 lc1990linux@gmail.com make integration_test_driver_extended.dart support writeResponseData--(done) (flutter/flutter#128382) 2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.1.1 (flutter/flutter#136762) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (flutter/flutter#136755) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) (flutter/flutter#136752) 2023-10-17 aran@arandonohue.com Support --web-header option for flutter run (flutter/flutter#136297) 2023-10-17 34871572+gmackall@users.noreply.github.com Add Android 14 physical devices to firebase tests (flutter/flutter#136736) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) (flutter/flutter#136746) 2023-10-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136750) 2023-10-17 katelovett@google.com Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (flutter/flutter#136744) 2023-10-17 15619084+vashworth@users.noreply.github.com Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136562) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (flutter/flutter#136739) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (flutter/flutter#136732) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable NexusLowRes API 29 (flutter/flutter#136686) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable the nexus 6p tests (flutter/flutter#136689) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown.
Solution for #136582