Fix memory leaks in DateRangePickerDialog. [prod-leak-fix] #136034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
requested changes
Oct 5, 2023
Member
|
@ksokolovskyi |
2 tasks
Contributor
Author
|
cc @polina-c |
polina-c
approved these changes
Oct 5, 2023
Contributor
|
LGTM. I would like @TahaTesser 's lgtm before merging this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 6, 2023
flutter/flutter@fe0275f...ad20089 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc9bc9e2c0d3 to 59b6b94e1a51 (1 revision) (flutter/flutter#136066) 2023-10-06 sokolovskyi.konstantin@gmail.com Fix memory leaks in DateRangePickerDialog. (flutter/flutter#136034) 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6492e1f8c315 to cc9bc9e2c0d3 (1 revision) (flutter/flutter#136062) 2023-10-06 5236035+fzyzcjy@users.noreply.github.com Tiny improve code style by using records instead of lists (flutter/flutter#135886) 2023-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27a674466094 to 6492e1f8c315 (1 revision) (flutter/flutter#136052) 2023-10-05 smartercallum@gmail.com Upload frame_request_pending_latency [attempt #2] (flutter/flutter#135890) 2023-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ff05464f42f to 27a674466094 (1 revision) (flutter/flutter#136050) 2023-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad83202a59a6 to 0ff05464f42f (1 revision) (flutter/flutter#136047) 2023-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8d53c5fe9f2 to ad83202a59a6 (2 revisions) (flutter/flutter#136040) 2023-10-05 engine-flutter-autoroll@skia.org Roll Packages from d654f75 to 6714d50 (3 revisions) (flutter/flutter#136039) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
This PR mainly fixes several memory leaks in the `DateRangePickerDialog`. ### Description - Fixes flutter#136033 by: 1) adding a disposal of several `RestorableValue`; 2) creating a separate `_DayItem` stateful widget that creates/updates/disposes internal `MaterialStatesController`. - Marks flutter#136036. ### Tests - Updates `test/material/date_picker_theme_test.dart` to use `testWidgetsWithLeakTracking`; - Updates `test/material/date_range_picker_test.dart` to use `testWidgetsWithLeakTracking`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes several memory leaks in the
DateRangePickerDialog.Description
RestorableValue;_DayItemstateful widget that creates/updates/disposes internalMaterialStatesController.Tests
test/material/date_picker_theme_test.dartto usetestWidgetsWithLeakTracking;test/material/date_range_picker_test.dartto usetestWidgetsWithLeakTracking.Pre-launch Checklist
///).