Call markNeedsPaint when adding overlayChild to Overlay
#135941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a31e94 to
4449c88
Compare
goderbauer
approved these changes
Oct 6, 2023
| const String tooltipText = 'TIP'; | ||
| const double _customPaddingValue = 10.0; | ||
|
|
||
| void _ensureTooltipVisible(GlobalKey key) { |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 7, 2023
flutter/flutter@ad20089...5207a30 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (flutter/flutter#136110) 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (flutter/flutter#136108) 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (flutter/flutter#136107) 2023-10-07 cbobbe@zulip.com bottom_sheet: Clarify doc about behavior when useSafeArea is false (flutter/flutter#134793) 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (flutter/flutter#136106) 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (flutter/flutter#136104) 2023-10-07 mateusfccp@gmail.com Simplify assertion in `AsyncSnapshot` (flutter/flutter#135899) 2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (flutter/flutter#136103) 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (flutter/flutter#136101) 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (flutter/flutter#136098) 2023-10-06 737941+loic-sharma@users.noreply.github.com [Windows] Add first Arm64 plugin tests (flutter/flutter#135512) 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (flutter/flutter#136094) 2023-10-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.22.0 (flutter/flutter#136095) 2023-10-06 31859944+LongCatIsLooong@users.noreply.github.com Call `markNeedsPaint` when adding overlayChild to `Overlay` (flutter/flutter#135941) 2023-10-06 zanderso@users.noreply.github.com Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (flutter/flutter#136097) 2023-10-06 fluttergithubbot@gmail.com Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (flutter/flutter#135566) 2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59b6b94e1a51 to 1bb228dfedfa (1 revision) (flutter/flutter#136082) 2023-10-06 polinach@google.com RenderEditable should dispose created layers. (flutter/flutter#135942) 2023-10-06 fluttergithubbot@gmail.com Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135961) 2023-10-06 engine-flutter-autoroll@skia.org Roll Packages from 6714d50 to e578a16 (2 revisions) (flutter/flutter#136074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…135941) Fixes flutter#134656 `_skipMarkNeesLayout` was meant to only skip `markNeedsLayout` calls. Re-painting is still needed when a child gets added/removed from the `Overlay`.
2 tasks
2 tasks
|
@LongCatIsLooong apologies if this is not the right way, but would you not consider backporting the fix for 3.16 (and maybe even 3.13)? We cannot yet upgrade to Flutter 3.19. Apparently creating a [CP] issue is the prerogative of the "contributor" - I guess that would be you. Both 3.13 and 3.16 include the broken OverlayPortal implementation. Unrelated to tooltips, we ran into a similar problem when using a conditionally built OverlayPortal directly: when the OverlayPortal is removed from the tree its overlay remains visible until something forces the right repaint (like a window size change). |
Contributor
Author
|
@HeinrichJanzing according to https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#what-if-the-issue-is-on-a-previous-stable it seems such process does exist. But the wiki also says the anyone can create CP requests. Could you follow https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#flutter-cherry-pick-process and see if you hit any obstacles? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134656
_skipMarkNeesLayoutwas meant to only skipmarkNeedsLayoutcalls. Re-painting is still needed when a child gets added/removed from theOverlay.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.