Skip to content

[conductor] Remove PublishChannel and use MPA command #135884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Oct 9, 2023
Merged

[conductor] Remove PublishChannel and use MPA command #135884

auto-submit merged 3 commits into from
Oct 9, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Oct 3, 2023

Move more of the playbook into conductor. The MPA command inputs are prone to human error.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@CaseyHillers CaseyHillers marked this pull request as ready for review October 9, 2023 16:19
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Oct 9, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but LGTM

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 9, 2023

auto label is removed for flutter/flutter/135884, due to - The status or check suite Linux_android android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot merged commit d963415 into flutter:master Oct 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
d963415 [conductor] Remove PublishChannel and use MPA command (flutte…
086e31a 
…r/flutter#135884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
d963415 [conductor] Remove PublishChannel and use MPA command (flutte…
f526e27 
…r/flutter#135884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
d963415 [conductor] Remove PublishChannel and use MPA command (flutte…
f30461e 
…r/flutter#135884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
d963415 [conductor] Remove PublishChannel and use MPA command (flutte…
a493682 
…r/flutter#135884)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
Roll Flutter from f52fe4f to 83134ac (25 revisions) (#5104)
bb9de56 
flutter/flutter@f52fe4f...83134ac

2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b3f9886fbf0 to 60e861dfe6b1 (1 revision) (flutter/flutter#136264)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from e354a13cfeab to 2b3f9886fbf0 (4 revisions) (flutter/flutter#136259)
2023-10-10 engine-flutter-autoroll@skia.org Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter/flutter#136258)
2023-10-10 sokolovskyi.konstantin@gmail.com RenderAnnotatedRegion should dispose created layers. (flutter/flutter#136086)
2023-10-10 polinach@google.com TestClipPaintingContext should dispose ContainerLayer (flutter/flutter#135949)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aa7cb057d22 to e354a13cfeab (1 revision) (flutter/flutter#136248)
2023-10-10 104349824+huycozy@users.noreply.github.com Migrate the "Non-speed related performance issues" issue template to Github forms (flutter/flutter#135130)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 171b4b26e68b to 9aa7cb057d22 (4 revisions) (flutter/flutter#136240)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d094401acb99 to 171b4b26e68b (1 revision) (flutter/flutter#136235)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92880e9847b3 to d094401acb99 (1 revision) (flutter/flutter#136233)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 51193f8f53eb to 92880e9847b3 (1 revision) (flutter/flutter#136232)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f2fa3ceb8a0 to 51193f8f53eb (4 revisions) (flutter/flutter#136228)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73da593bac54 to 8f2fa3ceb8a0 (2 revisions) (flutter/flutter#136220)
2023-10-09 chillers@google.com [conductor] Remove PublishChannel and use MPA command (flutter/flutter#135884)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0966f62d7101 to 73da593bac54 (1 revision) (flutter/flutter#136216)
2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/painting #1 (flutter/flutter#136167)
2023-10-09 41873024+droidbg@users.noreply.github.com [leak-tracking] Cover testwidgets with leak tracking in test/gestures (flutter/flutter#136166)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 81e5bf29dee4 to 0966f62d7101 (1 revision) (flutter/flutter#136215)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22ce5c6a45e2 to 81e5bf29dee4 (3 revisions) (flutter/flutter#136211)
2023-10-09 110993981+htoor3@users.noreply.github.com [web] Fix `page up` `page down` `home` `end` shortcut behavior on web (flutter/flutter#135454)
2023-10-09 gspencergoog@users.noreply.github.com Update `MediaQuery` documentation to highlight asynchronous nature of size (flutter/flutter#135719)
2023-10-09 47866232+chunhtai@users.noreply.github.com Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rou� (flutter/flutter#134554)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) (flutter/flutter#136205)
2023-10-09 engine-flutter-autoroll@skia.org Roll Packages from e578a16 to 7de08ec (4 revisions) (flutter/flutter#136202)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 664f5e833871 to 429a242b0db6 (2 revisions) (flutter/flutter#136201)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@Mairramer
[conductor] Remove PublishChannel and use MPA command (flutter#135884)
209429b 
Move more of the playbook into conductor. The MPA command inputs are prone to human error.

Update text_field_test.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaseyHillers @christopherfujino