Skip to content

Cover more test/widgets tests with leak tracking #3 #134576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 4 commits into from
Sep 14, 2023
Merged

Cover more test/widgets tests with leak tracking #3 #134576

polina-c merged 4 commits into from
Sep 14, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 12, 2023

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Tests

  • Updates form_test.dart to use testWidgetsWithLeakTracking;
  • Updates fractionally_sized_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates framework_test.dart to use testWidgetsWithLeakTracking;
  • Updates gesture_detector_semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates gesture_detector_test.dart to use testWidgetsWithLeakTracking;
  • Updates gesture_disambiguation_test.dart to use testWidgetsWithLeakTracking;
  • Updates global_keys_duplicated_test.dart to use testWidgetsWithLeakTracking;
  • Updates global_keys_moving_test.dart to use testWidgetsWithLeakTracking;
  • Updates grid_paper_test.dart to use testWidgetsWithLeakTracking;
  • Updates grid_view_layout_test.dart to use testWidgetsWithLeakTracking;
  • Updates grid_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates heroes_test.dart to use testWidgetsWithLeakTracking;
  • Updates hit_testing_test.dart to use testWidgetsWithLeakTracking;
  • Updates hyperlink_test.dart to use testWidgetsWithLeakTracking;
  • Updates icon_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_filter_quality_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_filter_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_headers_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_icon_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_resolution_test.dart to use testWidgetsWithLeakTracking;
  • Updates image_rtl_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Sep 12, 2023
This was referenced Sep 12, 2023
Closed
Closed
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 12, 2023

cc @polina-c

@goderbauer goderbauer requested a review from polina-c September 12, 2023 22:02
polina-c
polina-c reviewed Sep 12, 2023
View reviewed changes
polina-c
polina-c reviewed Sep 12, 2023
View reviewed changes
polina-c
polina-c reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small comments

@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 13, 2023

@polina-c thanks for the review.

@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 13, 2023

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking?
Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

@ksokolovskyi ksokolovskyi changed the title Cover more test/widgets tests with leak tracking Cover more test/widgets tests with leak tracking #3 Sep 13, 2023
@polina-c
Copy link
Contributor

polina-c commented Sep 14, 2023 •
edited
Loading

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking? Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

Thanks for asking. I will add answer to top description of the main issue. Let's convert just one test. It will be enough for issue resolution. When we have too many issues, we need to stop conversion and fix them, before going forward.

polina-c
polina-c approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 14, 2023

auto label is removed for flutter/flutter/134576, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@polina-c polina-c merged commit ff10c52 into flutter:master Sep 14, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 14, 2023

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking? Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

Thanks for asking. I will add answer to top description of the main issue. Let's convert just one test. It will be enough for issue resolution. When we have too many issues, we need to stop conversion and fix them, before going forward.

Thanks a lot for the answer and review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…
64fccac 
…lutter/flutter#134576)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…
a2172c9 
…lutter/flutter#134576)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…
9298c76 
…lutter/flutter#134576)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (#4934)
f194f59 
flutter/flutter@58ba6c2...72b69f9

2023-09-15 polinach@google.com Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 engine-flutter-autoroll@skia.org Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 leroux_bruno@yahoo.fr Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 k_hayashi@yumemi.co.jp Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 sokolovskyi.konstantin@gmail.com Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 zanderso@users.noreply.github.com Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 pavel.mazhnik@gmail.com [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 47866232+chunhtai@users.noreply.github.com Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 15619084+vashworth@users.noreply.github.com Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 82763757+NobodyForNothing@users.noreply.github.com Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 github@alexv525.com � Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 leroux_bruno@yahoo.fr Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 30870216+gaaclarke@users.noreply.github.com Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 15, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking #3 (flutter#134576)
a05f576
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…
352735b 
…lutter/flutter#134576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksokolovskyi @polina-c