Cover focus tests with leak tracking #134457

ksokolovskyi · 2023-09-11T19:52:14Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

Updates focus_manager_test.dart to use testWidgetsWithLeakTracking;
Updates focus_scope_test.dart to use testWidgetsWithLeakTracking;
Updates focus_traversal_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-09-11T19:53:02Z

cc @polina-c

XilaiZhang · 2023-09-11T20:49:16Z

side note: I was testing out a few things and Google Testing wasn't triggered on this PR, it should be triggered on future commits pushed to this pr.

polina-c · 2023-09-11T21:22:27Z

@XilaiZhang , i merged master, but I do not see google testing in the list. Is it ok to merge if everything is green or I need to trigger google testing somehow?

auto-submit · 2023-09-11T21:45:29Z

auto label is removed for flutter/flutter/134457, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

chunhtai

LGTM

XilaiZhang · 2023-09-11T23:14:49Z

Umm looks like Google Testing was pending due to merge conflict, very likely due to flutter rolls being 2 weeks behind current head.

I sent cl/564524744 to better manifest the information on propagating merge conflict information

ksokolovskyi · 2023-09-12T05:45:11Z

@polina-c @chunhtai @XilaiZhang thanks for the review!

flutter/flutter@219efce...4e7a07a 2023-09-12 katelovett@google.com Remove chip tooltip deprecations (flutter/flutter#134486) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a8ddaeecf8a to d4698c65aa8d (2 revisions) (flutter/flutter#134553) 2023-09-12 katelovett@google.com Remove deprecated TextSelectionOverlay.fadeDuration (flutter/flutter#134485) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25be03186d82 to 8a8ddaeecf8a (1 revision) (flutter/flutter#134545) 2023-09-12 engine-flutter-autoroll@skia.org Roll Packages from ef0c65e to e04ba88 (5 revisions) (flutter/flutter#134546) 2023-09-12 47866232+chunhtai@users.noreply.github.com Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rouâ�¦ (flutter/flutter#134550) 2023-09-12 fluttergithubbot@gmail.com Marks Windows_android channels_integration_test_win to be unflaky (flutter/flutter#133129) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4091167e402d to 25be03186d82 (1 revision) (flutter/flutter#134536) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54175da7ba90 to 4091167e402d (1 revision) (flutter/flutter#134532) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 85f3f02e5c37 to 54175da7ba90 (2 revisions) (flutter/flutter#134531) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1369ab35aaa7 to 85f3f02e5c37 (1 revision) (flutter/flutter#134519) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2f1efe5967f3 to 1369ab35aaa7 (1 revision) (flutter/flutter#134512) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d8265cbc133 to 2f1efe5967f3 (3 revisions) (flutter/flutter#134511) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from ee7215553deb to 4d8265cbc133 (1 revision) (flutter/flutter#134506) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6ddee4423d2c to ee7215553deb (2 revisions) (flutter/flutter#134505) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from a98348946d61 to 6ddee4423d2c (1 revision) (flutter/flutter#134490) 2023-09-12 xubaolin@oppo.com [New feature] Allowing the `ListView` slivers to have different extents while still having scrolling performance (flutter/flutter#131393) 2023-09-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8389ad914b21 to a98348946d61 (4 revisions) (flutter/flutter#134487) 2023-09-12 kouhei.seino@woven-planet.global ScaleGestureRecognizer: make pointerCount public (flutter/flutter#127310) 2023-09-11 chinmay@blend.to Fix DataTable example not being scrollable (flutter/flutter#131556) 2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06696e768c1b to 8389ad914b21 (2 revisions) (flutter/flutter#134469) 2023-09-11 christopherfujino@gmail.com [flutter_tools] disallow -O0 for flutter build web (flutter/flutter#134185) 2023-09-11 sokolovskyi.konstantin@gmail.com Cover focus tests with leak tracking (flutter/flutter#134457) 2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0774ddcda9b0 to 06696e768c1b (4 revisions) (flutter/flutter#134462) 2023-09-11 sokolovskyi.konstantin@gmail.com Fix memory leak in RenderAnimatedSize (flutter/flutter#133653) 2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e42fd367adcb to 0774ddcda9b0 (1 revision) (flutter/flutter#134447) 2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d593002b7159 to e42fd367adcb (1 revision) (flutter/flutter#134444) 2023-09-11 engine-flutter-autoroll@skia.org Roll Packages from aaae5ef to ef0c65e (6 revisions) (flutter/flutter#134445) 2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b5961cbc40d to d593002b7159 (3 revisions) (flutter/flutter#134439) 2023-09-11 polinach@google.com Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. (flutter/flutter#134395) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update focus tests to use leak tracking

f96440b

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Sep 11, 2023

Merge branch 'master' into focus-leak-tracking-tests

73fdbbc

polina-c approved these changes Sep 11, 2023

View reviewed changes

Merge branch 'master' into focus-leak-tracking-tests

10e918f

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023

polina-c requested a review from chunhtai September 11, 2023 21:49

chunhtai approved these changes Sep 11, 2023

View reviewed changes

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023

polina-c merged commit adaf78a into flutter:master Sep 11, 2023

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to 127c76b91bef (22 revisions) flutter/packages#4905

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

e3fa6e6

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to bdd96032a053 (24 revisions) flutter/packages#4906

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

7aaca5d

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to 5900c4baa751 (25 revisions) flutter/packages#4907

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

fcd0e7e

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to f9aef4f21e31 (26 revisions) flutter/packages#4908

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

a2a3849

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to 90ae98f57642 (28 revisions) flutter/packages#4909

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

49df19d

engine-flutter-autoroll mentioned this pull request Sep 12, 2023

Roll Flutter from 219efce7f16d to 4e7a07af882c (30 revisions) flutter/packages#4910

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

6623db6

HansMuller mentioned this pull request Sep 15, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

adaf78a Cover focus tests with leak tracking (flutter/flutter#134457)

cad2523

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cover focus tests with leak tracking #134457

Cover focus tests with leak tracking #134457

Uh oh!

ksokolovskyi commented Sep 11, 2023

Uh oh!

ksokolovskyi commented Sep 11, 2023

Uh oh!

XilaiZhang commented Sep 11, 2023

Uh oh!

polina-c commented Sep 11, 2023

Uh oh!

auto-submit bot commented Sep 11, 2023

Uh oh!

chunhtai left a comment

Uh oh!

XilaiZhang commented Sep 11, 2023

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Cover focus tests with leak tracking #134457

Cover focus tests with leak tracking #134457

Uh oh!

Conversation

ksokolovskyi commented Sep 11, 2023

Description

Tests

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Sep 11, 2023

Uh oh!

XilaiZhang commented Sep 11, 2023

Uh oh!

polina-c commented Sep 11, 2023

Uh oh!

auto-submit bot commented Sep 11, 2023

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

XilaiZhang commented Sep 11, 2023

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants