SearchBar should listen to changes to the SearchController and update suggestions on change #134337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| super.initState(); | ||
| _viewRect = widget.viewRect; | ||
| _controller = widget.searchController; | ||
| _controller.addListener(updateSuggestions); |
Contributor
There was a problem hiding this comment.
I think the updateSuggestions call can be removed from defaultTrailing and defaultLeading in the onPressed since this change will call updateSuggestions when the controller changes its value.
Renzo-Olivares
approved these changes
Sep 12, 2023
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM with one comment. Thanks for the contribution @bryanoli! I think I'm leaning towards the method used in this PR vs an update method added to SearchController. I think its reasonable to have this functionality by default, and internal defaultTrailing and defaultLeading already updateSuggestions by default.
cc @QuncCccccc for any insights/thoughts on this issue.
QuncCccccc
approved these changes
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
…d update suggestions on change (flutter/flutter#134337)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2023
…d update suggestions on change (flutter/flutter#134337)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 13, 2023
Roll Flutter from 83134ac to 3865e49 (80 revisions) flutter/flutter@83134ac...3865e49 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from e94f191d0ba4 to f9aed0267352 (2 revisions) (flutter/flutter#136537) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40ddc30b9d6c to e94f191d0ba4 (1 revision) (flutter/flutter#136532) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5acdac549034 to 40ddc30b9d6c (1 revision) (flutter/flutter#136526) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from b59d779d4f7f to 5acdac549034 (2 revisions) (flutter/flutter#136523) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from dc30b4cd0239 to b59d779d4f7f (2 revisions) (flutter/flutter#136521) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31ec5e31a914 to dc30b4cd0239 (1 revision) (flutter/flutter#136518) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7a6172e9d34c to 31ec5e31a914 (1 revision) (flutter/flutter#136516) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from ffb3b5b67f61 to 7a6172e9d34c (1 revision) (flutter/flutter#136515) 2023-10-13 sokolovskyi.konstantin@gmail.com SearchAnchor should dispose created FocusNode and SearchController. (flutter/flutter#136120) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from dee90f16aacd to ffb3b5b67f61 (2 revisions) (flutter/flutter#136506) 2023-10-13 tvolkert@users.noreply.github.com Make constraints a covariant argument in RenderBox.computeDryLayout() (flutter/flutter#136432) 2023-10-12 yjbanov@google.com [web] remove loading indicator in -d web-server builds (flutter/flutter#136482) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) (flutter/flutter#136502) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) (flutter/flutter#136492) 2023-10-12 xubaolin@oppo.com [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136239) 2023-10-12 gspencergoog@users.noreply.github.com Allow `TapRegion` to consume tap events (flutter/flutter#136305) 2023-10-12 goderbauer@google.com Fix doc TODO (flutter/flutter#136485) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) (flutter/flutter#136478) 2023-10-12 goderbauer@google.com Bump file,process,process_runner (flutter/flutter#136418) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (flutter/flutter#136467) 2023-10-12 104349824+huycozy@users.noreply.github.com Fix PageView API doc sample fails on Desktop and Web (flutter/flutter#135910) 2023-10-12 derekx@google.com Add `--trace-to-file` option to `flutter run` (flutter/flutter#135713) 2023-10-12 christopherfujino@gmail.com [flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives (flutter/flutter#136424) 2023-10-12 109253501+pdblasi-google@users.noreply.github.com Updates references to `finders.dart` in `controller.dart` to use a namespace. (flutter/flutter#136423) 2023-10-12 15619084+vashworth@users.noreply.github.com Change some tests to run on macs without iOS devices attached (flutter/flutter#136463) 2023-10-12 engine-flutter-autoroll@skia.org Roll Packages from 4b483f2 to 93c3f69 (9 revisions) (flutter/flutter#136461) 2023-10-12 15619084+vashworth@users.noreply.github.com Fix typo in function name (flutter/flutter#136273) 2023-10-12 tessertaha@gmail.com Fix chip widgets don't the apply provided `iconTheme` (flutter/flutter#135751) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) (flutter/flutter#136450) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) (flutter/flutter#136442) 2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) (flutter/flutter#136431) 2023-10-12 36861262+QuncCccccc@users.noreply.github.com Floating `SnackBar` should always float above the bottom widgets (flutter/flutter#136411) 2023-10-12 66151079+bryanoli@users.noreply.github.com SearchBar should listen to changes to the SearchController and update suggestions on change (flutter/flutter#134337) 2023-10-11 kevmoo@users.noreply.github.com Allow latest pkg:material_color_utilities (flutter/flutter#132445) 2023-10-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) (flutter/flutter#136422) 2023-10-11 kevinjchisholm@google.com Create template for umbrella issues (flutter/flutter#134235) 2023-10-11 737941+loic-sharma@users.noreply.github.com [Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test (flutter/flutter#136401) 2023-10-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b1b4b97f787 to 8bf1460892c6 (4 revisions) (flutter/flutter#136414) 2023-10-11 christopherfujino@gmail.com Stop recommending android sdk root (flutter/flutter#136296) 2023-10-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) (flutter/flutter#136404) 2023-10-11 jacksongardner@google.com Switch to Chrome for Testing instead of vanilla Chromium. (flutter/flutter#136214) 2023-10-11 derekx@google.com Reland "Switch flutter_tools to run frontend server from AOT snapshot" (flutter/flutter#136282) 2023-10-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) (flutter/flutter#136397) 2023-10-11 katelovett@google.com Fix some deprecation details (flutter/flutter#136385) 2023-10-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) (flutter/flutter#136392) 2023-10-11 41873024+droidbg@users.noreply.github.com [leak-tracking] Add leak tracking in test/rendering - 1 (flutter/flutter#136275) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a listener to the
SearchController, so that thesuggestionBuildercan be updated when theSearchControllerchanges.Another method we can possibly do is have an update method on
SearchController, so that the user can manually update the suggestions instead of us doing it automatically.Fixes #132161
Pre-launch Checklist
///).