l10n-related documentation improvements #133114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
approved these changes
Aug 23, 2023
Member
There was a problem hiding this comment.
nit: stick to one style, either use getFooTranslation or getFooTranslation() everywhere in this enumeration?
Member
There was a problem hiding this comment.
Is the change from plural ARBs to singular ARB intentional? Is Cupertino special that way compared to Material and Widgets above?
Contributor
Author
There was a problem hiding this comment.
no that was just a typo, fixed
Contributor
Author
|
thanks for the detailed and careful review, much appreciated! |
Contributor
|
auto label is removed for flutter/flutter/133114, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/133114, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 25, 2023
flutter/flutter@deeb811...61d9f55 2023-08-25 43759233+kenzieschmoll@users.noreply.github.com Update flutter packages to pick up latest vm_service (flutter/flutter#133335) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (flutter/flutter#133337) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (flutter/flutter#133333) 2023-08-25 tessertaha@gmail.com Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (flutter/flutter#133141) 2023-08-25 tessertaha@gmail.com Fix `Chip.shape`'s side is not used when provided in Material 3 (flutter/flutter#132941) 2023-08-25 72562119+tgucio@users.noreply.github.com Dispose overlay entries (flutter/flutter#132826) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (flutter/flutter#133320) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (flutter/flutter#133309) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (flutter/flutter#133307) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (flutter/flutter#133305) 2023-08-25 chingjun@google.com Allow passing verbose log from flutter daemon. (flutter/flutter#132828) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (flutter/flutter#133298) 2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (flutter/flutter#133296) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/flutter#133281) 2023-08-24 ian@hixie.ch Update the tool to know about all our new platforms (flutter/flutter#132423) 2023-08-24 ian@hixie.ch l10n-related documentation improvements (flutter/flutter#133114) 2023-08-24 73116038+whiskeyPeak@users.noreply.github.com Add hover duration for `Inkwell` widget (flutter/flutter#132176) 2023-08-24 yjbanov@google.com [web] benchmark the benchmark harness overhead (flutter/flutter#132999) 2023-08-24 polinach@google.com Users of ChangeNotifier should dispatch event of object creation in constructor. (flutter/flutter#133210) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (flutter/flutter#133225) 2023-08-24 31859944+LongCatIsLooong@users.noreply.github.com Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (flutter/flutter#132679) 2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa98a9d2e86f to 965501a25d92 (24 revisions) (flutter/flutter#133272) 2023-08-24 andrewrkolos@gmail.com handle exceptions raised while searching for configured android studio (flutter/flutter#133180) 2023-08-24 christopherfujino@gmail.com Fix mac tool_integration_tests with Xcode 15 (flutter/flutter#133217) 2023-08-24 engine-flutter-autoroll@skia.org Roll Packages from 3060b1a to 383bffa (3 revisions) (flutter/flutter#133256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.