Add --experimental-wasm-type-reflection and support newer emscripten builds.
#133084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
approved these changes
Aug 23, 2023
Comment on lines
+90
to
+93
| final String jsFlags = options.enableWasmGC ? <String>[ | ||
| '--experimental-wasm-gc', | ||
| '--experimental-wasm-type-reflection', | ||
| ].join(' ') : ''; |
Contributor
There was a problem hiding this comment.
Minor suggestion: if it were me, I would probably do it this way:
Suggested change
| final String jsFlags = options.enableWasmGC ? <String>[ | |
| '--experimental-wasm-gc', | |
| '--experimental-wasm-type-reflection', | |
| ].join(' ') : ''; | |
| const String kWasmGCFlags = | |
| '--experimental-wasm-gc ' | |
| '--experimental-wasm-type-reflection'; |
Then below:
if (options.enableWasmGC) '--js-flags=$kWasmGCFlags';But this is just my personal preference.
Contributor
Author
There was a problem hiding this comment.
I did it this way because I feel like the join call is less error prone than trying to remember to put spaces in the right places in the string yourself. It's the same pattern we use in the compile unit tests step in the engine, which is where I copied it from. When we've had to change which flags are being added, it's a little simpler to just add or remove a flag from this list than to try to reason about how the string is going to be constructed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 24, 2023
…mscripten builds. (flutter/flutter#133084)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 24, 2023
…mscripten builds. (flutter/flutter#133084)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 24, 2023
flutter/flutter@bd836cc...deeb811 2023-08-24 zanderso@users.noreply.github.com Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255) 2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224) 2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220) 2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214) 2023-08-23 katelovett@google.com Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175) 2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211) 2023-08-23 katelovett@google.com Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173) 2023-08-23 polinach@google.com Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060) 2023-08-23 goderbauer@google.com Enable literal_only_boolean_expressions (flutter/flutter#133186) 2023-08-23 47866232+chunhtai@users.noreply.github.com Add android analyzer commands for applinks (flutter/flutter#131009) 2023-08-23 reidbaker@google.com Bump memory usage in gradle for platform views (flutter/flutter#133155) 2023-08-23 christopherfujino@gmail.com [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097) 2023-08-23 goderbauer@google.com Remove deprecated *TestValues from TestWindow (flutter/flutter#131098) 2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165) 2023-08-23 mdebbar@google.com [web] Remove unnecessary lint ignore (flutter/flutter#133164) 2023-08-23 jacksongardner@google.com Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084) 2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…mscripten builds. (flutter/flutter#133084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes to prepare for incoming changes to skwasm in the web engine:
WebAssembly.Functionconstructor inskwasm, which is hidden behind the--experimental-wasm-type-reflectionflag. We need to pass that when running skwasm benchmarks.wasmExportsproperty instead of theasmproperty. Make sure to support either, if passed.