Skip to content

Conversation

@gmilou
Copy link
Contributor

@gmilou gmilou commented Aug 18, 2023

This continues work on #130946, and is a follow up to: 58019b3

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 18, 2023
@gmilou gmilou marked this pull request as draft August 18, 2023 23:12
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmilou gmilou force-pushed the matrix-example branch 2 times, most recently from f0e8036 to 077e816 Compare August 22, 2023 21:49
@gmilou gmilou marked this pull request as ready for review August 22, 2023 22:09
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser requested a review from Piinks August 23, 2023 15:23
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thank you for contributing!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 25, 2023

auto label is removed for flutter/flutter/132874, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Aug 25, 2023

The Google testing check is not working here, I am going to manually merge this since I know it will not break any Google tests.

@Piinks Piinks merged commit 40af7db into flutter:master Aug 25, 2023
@gmilou
Copy link
Contributor Author

gmilou commented Aug 25, 2023

Thanks Kate !

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 26, 2023
flutter/flutter@61d9f55...229b74d

2023-08-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e280ed21f923 to c9b584d59219 (1 revision) (flutter/flutter#133380)
2023-08-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 63fdf8a6701c to e280ed21f923 (3 revisions) (flutter/flutter#133378)
2023-08-26 polinach@google.com _SelectableFragment should dispatch creation in constructor. (flutter/flutter#133351)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53595c937df1 to 63fdf8a6701c (1 revision) (flutter/flutter#133366)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ec7b89f3a6b to 53595c937df1 (4 revisions) (flutter/flutter#133362)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1471967afb9b to 1ec7b89f3a6b (6 revisions) (flutter/flutter#133355)
2023-08-25 ian@hixie.ch Fix locking to work with flutter and dart running simultaneously (flutter/flutter#133350)
2023-08-25 chinmoy12c@gmail.com Adds callback onWillAcceptWithDetails in DragTarget. (flutter/flutter#131545)
2023-08-25 katelovett@google.com Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher (flutter/flutter#133183)
2023-08-25 katelovett@google.com Remove deprecated androidOverscrollIndicator from ScrollBehaviors (flutter/flutter#133181)
2023-08-25 139406084+gmilou@users.noreply.github.com Add an example showing how to use a MatrixTransition. (flutter/flutter#132874)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3dcd2179336d to 1471967afb9b (3 revisions) (flutter/flutter#133342)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 33fca02451ef to 3dcd2179336d (3 revisions) (flutter/flutter#133340)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller
Copy link
Contributor

NICE

Screen.Recording.2023-09-01.at.11.49.17.AM.mov

@TahaTesser
Copy link
Member

@HansMuller
VERY NICE INDEED!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants