Fix extent for null returning builder in GridView #132511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
approved these changes
Aug 15, 2023
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Contributor
|
@Piinks Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 16, 2023
flutter/flutter@f0e7c51...2502b51 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (flutter/flutter#132655) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (flutter/flutter#132649) 2023-08-16 whesse@google.com Fix flutter_tools use of --local-engine-host (flutter/flutter#132648) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (flutter/flutter#132623) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (flutter/flutter#132621) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (flutter/flutter#132618) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (flutter/flutter#132612) 2023-08-16 jonahwilliams@google.com Revert "Reorganize and clarify API doc generator" (flutter/flutter#132613) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) (flutter/flutter#132609) 2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) (flutter/flutter#132608) 2023-08-16 tessertaha@gmail.com [Reland] #131609 (flutter/flutter#132555) 2023-08-15 dkwingsmt@users.noreply.github.com Explain the keyboard manager protocol (flutter/flutter#132533) 2023-08-15 katelovett@google.com Fix extent for null returning builder in GridView (flutter/flutter#132511) 2023-08-15 gspencergoog@users.noreply.github.com Reorganize and clarify API doc generator (flutter/flutter#132353) 2023-08-15 gspencergoog@users.noreply.github.com Fixing a memory leak in About box/dialog overlays (flutter/flutter#130842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130685
This fixes an issue where a GridView/SliverGrid with a SliverChildBuilderDelegate would still reflect a max scroll extent of infinity after returning null from the builder. This change incorporates the same way we handle this case in SliverList:
flutter/packages/flutter/lib/src/rendering/sliver_list.dart
Lines 305 to 307 in 6d87a23
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.