Skip to content

Add more use cases to a11y assessments #132325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 16, 2023
Merged

Add more use cases to a11y assessments #132325

auto-submit merged 2 commits into from
Aug 16, 2023

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 10, 2023 •
edited
Loading

see go/flutter-gar-reporting-q3-2023

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Aug 10, 2023
@chunhtai chunhtai requested a review from yjbanov August 10, 2023 19:25
yjbanov
yjbanov approved these changes Aug 15, 2023
View reviewed changes
dev/a11y_assessments/test/date_picker_test.dart Outdated
Copy link
Contributor

@yjbanov yjbanov Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these tests run on CI?

Copy link
Contributor Author

@chunhtai chunhtai Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is part of framework_misc subshard, example https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8773120410313014785/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/test_stdout

@chunhtai chunhtai force-pushed the add-a11y-use-cases branch from 5700692 to 1f1ab3f Compare August 15, 2023 20:00
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2023
@auto-submit auto-submit bot merged commit 99790cc into flutter:master Aug 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
c09e2b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
8646da9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
72a75bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
698b46c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
167cce5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
99790cc Add more use cases to a11y assessments (flutter/flutter#132325)
df8f657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai @yjbanov