Skip to content

Added new gallery benchmark test that forces opengles. #131796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaaclarke merged 4 commits into from
Aug 3, 2023
Merged

Added new gallery benchmark test that forces opengles. #131796

gaaclarke merged 4 commits into from
Aug 3, 2023

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Aug 2, 2023

fixes #131782

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the opengles-new-gallery-benchmark branch 2 times, most recently from 209d6cd to 1a30e79 Compare August 2, 2023 18:19
@gaaclarke gaaclarke force-pushed the opengles-new-gallery-benchmark branch from 1a30e79 to 81e0a1a Compare August 2, 2023 18:22
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 2, 2023
@gaaclarke gaaclarke requested a review from zanderso August 2, 2023 19:45
zanderso
zanderso reviewed Aug 2, 2023
View reviewed changes
dev/devicelab/lib/tasks/perf_tests.dart

if (forceOpenGLES ?? false) {
assert(enableImpeller!);
_addOpenGLESToManifest(testDirectory);
Copy link
Member

@zanderso zanderso Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably overly paranoid, but I think restoring the file to its original contents in a finally {} couldn't hurt.

Copy link
Member Author

@gaaclarke gaaclarke Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an error inside of _addOpenGLESToManifest there is no need to restore the file since the file is only edited in the last line.

It looks like writeAsStringSync is not atomic so if writing somehow failed it could be garbage. But the cases where the writing fail would probably be an environment where the test wouldn't execute properly anyways, no?

This test is modifying its own copy of the gallery in its own temporary directory so this shouldn't effect other tests, see https://github.com/flutter/flutter/pull/131796/files#diff-514ad19bc7a9b9e196b1568127fed85ee10552d62baa32f960d694a98cfc83f1R16.

Let me know if there is a situation I'm not considering.

Copy link
Member

@zanderso zanderso Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said, I'm maybe being a bit paranoid, but suppose _addOpenGLESToManifest is used by mistake for an some other integration test that lives in flutter/flutter, and that the change to the xml file persists by mistake across multiple benchmark runs.

Copy link
Member Author

@gaaclarke gaaclarke Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, done.

@gaaclarke gaaclarke requested a review from zanderso August 2, 2023 20:21
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@zanderso
Copy link
Member

zanderso commented Aug 3, 2023

Google testing looks stuck. @CaseyHillers Should "Pull request has been added to the roll queue" turn the presub check green?

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Aug 3, 2023

Google testing looks stuck. @CaseyHillers Should "Pull request has been added to the roll queue" turn the presub check green?

It looks like this was having issues applying the patch. @XilaiZhang submitted a fix for it yesterday, and was rolled out to production this morning.

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Aug 3, 2023

Google testing looks stuck. @CaseyHillers Should "Pull request has been added to the roll queue" turn the presub check green?

It looks like this was having issues applying the patch. @XilaiZhang submitted a fix for it yesterday, and was rolled out to production this morning.

Just as a side note, the roll job version starting at 14:30 pm yesterday would have included the fix CL. provided updates in b/294383154

@gaaclarke gaaclarke mentioned this pull request Aug 3, 2023
Merged
8 tasks
@gaaclarke
Copy link
Member Author

gaaclarke commented Aug 3, 2023 •
edited
Loading

@CaseyHillers @XilaiZhang The associated CL for Google Testing doesn't look right, it should include these changes right? ( cl/553509627)

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Aug 3, 2023

@CaseyHillers @XilaiZhang The associated CL for Google Testing doesn't look, right? It should include these changes right? ( cl/553509627)

That CL is correct. Nothing in dev/ is imported by Google, so only your changes under packages/ were rolled. In this case, it's only the flutter_tools/pubspec.yaml

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Aug 3, 2023

ah indeed its now working as expected. another proof that the fix CL works. great!

@gaaclarke gaaclarke merged commit 4247e1e into flutter:master Aug 3, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
4247e1e Added new gallery benchmark test that forces opengles. (flutt…
3d102e7 
…er/flutter#131796)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
4247e1e Added new gallery benchmark test that forces opengles. (flutt…
b605f07 
…er/flutter#131796)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 4, 2023
@engine-flutter-autoroll
Roll Flutter from c00d241 to 2ba9f7b (25 revisions) (#4646)
11bb9ec 
flutter/flutter@c00d241...2ba9f7b

2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from d15a02a8191c to badca1f7f8c9 (1 revision) (flutter/flutter#131928)
2023-08-04 polinach@google.com Upgrade packages. (flutter/flutter#131927)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0725a6f519d0 to d15a02a8191c (2 revisions) (flutter/flutter#131924)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c912e3417e68 to 0725a6f519d0 (2 revisions) (flutter/flutter#131917)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03137a3b9b81 to c912e3417e68 (2 revisions) (flutter/flutter#131913)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from de0ec1c971ab to 03137a3b9b81 (1 revision) (flutter/flutter#131912)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from e3f75650ac5f to de0ec1c971ab (2 revisions) (flutter/flutter#131910)
2023-08-04 andrewrkolos@gmail.com make `--dart-define` override redundant values in `--dart-define-from-file` (flutter/flutter#131088)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca8d852eddfc to e3f75650ac5f (1 revision) (flutter/flutter#131907)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 098ec489585e to ca8d852eddfc (2 revisions) (flutter/flutter#131905)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4c62dd81d136 to 098ec489585e (2 revisions) (flutter/flutter#131903)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c1de9b8afba to 4c62dd81d136 (4 revisions) (flutter/flutter#131902)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (flutter/flutter#131897)
2023-08-03 tessertaha@gmail.com Fix TimePicker token issue link (flutter/flutter#131863)
2023-08-03 30870216+gaaclarke@users.noreply.github.com [Impeller] Add animated_blur_backdrop_filter_perf execution on samsung vulkan and opengles (flutter/flutter#131864)
2023-08-03 zanderso@users.noreply.github.com Revert "Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions)" (flutter/flutter#131896)
2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 4cc0b3dab001 to b08e1410a06a (9 revisions) (flutter/flutter#131880)
2023-08-03 30870216+gaaclarke@users.noreply.github.com Added new gallery benchmark test that forces opengles. (flutter/flutter#131796)
2023-08-03 engine-flutter-autoroll@skia.org Roll Packages from 4e4961a to d00c1f9 (10 revisions) (flutter/flutter#131866)
2023-08-03 christopherfujino@gmail.com manual pub package roll (flutter/flutter#131804)
2023-08-03 ychris@google.com remove Mac_ios ios_app_with_extensions_test (flutter/flutter#131806)
2023-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46f3e099ad04 to 4cc0b3dab001 (3 revisions) (flutter/flutter#131854)
2023-08-03 47866232+chunhtai@users.noreply.github.com Adds a11y assessment sample app (flutter/flutter#131716)
2023-08-03 60728110+MahmoudZayad@users.noreply.github.com Remove target Staging_build_linux framework_tests_misc (flutter/flutter#126959)
2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 4c1157b9da54 to 46f3e099ad04 (3 revisions) (flutter/flutter#131848)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Add benchmark that directly compares vulkan / opengl

4 participants

@gaaclarke @zanderso @CaseyHillers @XilaiZhang