Skip to content

PaginatedDataTable improvements #131374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 15, 2023
Merged

PaginatedDataTable improvements #131374

auto-submit merged 1 commit into from
Aug 15, 2023

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 27, 2023 •
edited
Loading

  • slightly improved assert message when row cell counts don't match column count.
  • more breadcrumbs in API documentation. more documentation in general.
  • added more documentation for the direction of the "ascending" arrow.
  • two samples for PaginatedDataTable.
  • make PaginatedDataTable support hot reloading across changes to the number of columns.
  • introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jul 27, 2023
@Hixie Hixie force-pushed the paginateddatatable1 branch 5 times, most recently from 9eeb318 to 53cf6fe Compare July 31, 2023 22:18
@Hixie Hixie force-pushed the paginateddatatable1 branch from 53cf6fe to 9668829 Compare August 3, 2023 23:50
@Hixie Hixie mentioned this pull request Aug 4, 2023
Open
@Hixie Hixie force-pushed the paginateddatatable1 branch 2 times, most recently from 299c075 to 6dc3bc4 Compare August 7, 2023 08:43
@Hixie Hixie force-pushed the paginateddatatable1 branch from 6dc3bc4 to 5766895 Compare August 13, 2023 22:53
HansMuller
HansMuller approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/paginated_data_table.dart Outdated
Copy link
Contributor

@HansMuller HansMuller Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding this method is pretty rare (I think Image is the only other widget that does it). A comment explaining the what and why would be helpful.

Copy link
Contributor Author

@Hixie Hixie Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@HansMuller HansMuller Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE, more interesting than I expected!

@Hixie Hixie force-pushed the paginateddatatable1 branch from 5766895 to 8a6cd7c Compare August 14, 2023 23:00
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 14, 2023

auto label is removed for flutter/flutter/131374, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie
PaginatedDataTable improvements
48479ca 
- slightly improved assert message when row cell counts don't match column count.
- more breadcrumbs in API documentation. more documentation in general.
- added more documentation for the direction of the "ascending" arrow.
- two samples for PaginatedDataTable.
- make PaginatedDataTable support hot reloading across changes to the number of columns.
- introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.
@Hixie Hixie force-pushed the paginateddatatable1 branch from 8a6cd7c to 48479ca Compare August 14, 2023 23:40
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2023
@auto-submit auto-submit bot merged commit ccdf826 into flutter:master Aug 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
f4648af
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
b2cfb0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
b7f69b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
2608f85
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
a32465c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
26742e6
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
Manual roll Flutter from 9b6945b to f0e7c51 (63 revisions) (#4719)
9bf208f 
Manual roll Flutter from 9b6945b to f0e7c51 (63 revisions)

Manual roll requested by bmparr@google.com

flutter/flutter@9b6945b...f0e7c51

2023-08-15 polinach@google.com Upgrade flutter packages. (flutter/flutter#132585)
2023-08-15 34871572+gmackall@users.noreply.github.com [integration_test] Update outdated onScreenshot signature in README code snippet (flutter/flutter#132409)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0760b5589c71 to 22f03ffdc290 (1 revision) (flutter/flutter#132580)
2023-08-15 58529443+srujzs@users.noreply.github.com Make completeError be a proper JS function (flutter/flutter#132492)
2023-08-15 goderbauer@google.com Analyze code snippets in flutter_driver docs (flutter/flutter#132337)
2023-08-15 54558023+keyonghan@users.noreply.github.com Skip backfiller for docs_publish (flutter/flutter#132510)
2023-08-15 ian@hixie.ch Further clarification of the TextSelectionControls migration (flutter/flutter#132539)
2023-08-15 engine-flutter-autoroll@skia.org Roll Packages from 08080ab to 84218b9 (1 revision) (flutter/flutter#132572)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c90670171a7 to 0760b5589c71 (1 revision) (flutter/flutter#132570)
2023-08-15 matanlurey@users.noreply.github.com Update `flutter_tools` internals related to Gradle/XCode to set `--local-engine-host`. (flutter/flutter#132346)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6bd7b717e110 to 2c90670171a7 (2 revisions) (flutter/flutter#132566)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9091107e594d to 6bd7b717e110 (1 revision) (flutter/flutter#132561)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a17130ac4d49 to 9091107e594d (2 revisions) (flutter/flutter#132553)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6975ee1b6de7 to a17130ac4d49 (5 revisions) (flutter/flutter#132550)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21aed05ad751 to 6975ee1b6de7 (1 revision) (flutter/flutter#132543)
2023-08-15 godofredoc@google.com Manual roll of docker focal version. (flutter/flutter#132536)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f1f912c0c7c7 to 21aed05ad751 (1 revision) (flutter/flutter#132540)
2023-08-15 ian@hixie.ch PaginatedDataTable improvements (flutter/flutter#131374)
2023-08-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d63eece6c37 to f1f912c0c7c7 (2 revisions) (flutter/flutter#132538)
2023-08-15 jonahwilliams@google.com [devicelab] fix name of flutter driver benchmark. (flutter/flutter#132527)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c8852827646 to 1d63eece6c37 (1 revision) (flutter/flutter#132534)
2023-08-14 109253501+pdblasi-google@users.noreply.github.com Updates `AutomatedTestWidgetsFlutterBinding.pump` to support microsecond precision (flutter/flutter#132401)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 785b24900a36 to 3c8852827646 (2 revisions) (flutter/flutter#132530)
2023-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/flutter#132525)
2023-08-14 jonahwilliams@google.com [devicelab] fix NAN/Inf in drawPoints benchmark. (flutter/flutter#132526)
2023-08-14 rmolivares@renzo-olivares.dev Selection area should move selection word by word on a long press drag (flutter/flutter#132518)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 56a0e2715dca to 785b24900a36 (10 revisions) (flutter/flutter#132522)
2023-08-14 jonahwilliams@google.com [flutter_tools] hide Skia specific rendering options. (flutter/flutter#132509)
2023-08-14 tessertaha@gmail.com Update menu examples for `SafeArea` (flutter/flutter#132390)
2023-08-14 matanlurey@users.noreply.github.com Update `dev/bots/test.dart` (and friends) to provide `--local-engine-host`. (flutter/flutter#132354)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46c11916f8d2 to 56a0e2715dca (2 revisions) (flutter/flutter#132508)
2023-08-14 jonahwilliams@google.com [devicelab] boot up benchmarks. (flutter/flutter#132148)
2023-08-14 engine-flutter-autoroll@skia.org Roll Packages from 9b15c2e to 08080ab (5 revisions) (flutter/flutter#132505)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from c125e1e23d4b to 46c11916f8d2 (1 revision) (flutter/flutter#132502)
2023-08-14 15619084+vashworth@users.noreply.github.com Fix log filtering and CI tests for iOS 17 physical devices (flutter/flutter#132491)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e8b2b61f648 to c125e1e23d4b (1 revision) (flutter/flutter#132496)
2023-08-14 polinach@google.com Unpin leak_tracker and handle breaking changes in API. (flutter/flutter#132352)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a392f29aa5 to 4e8b2b61f648 (2 revisions) (flutter/flutter#132490)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f50ad637de75 to 62a392f29aa5 (1 revision) (flutter/flutter#132487)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9cebd2015688 to f50ad637de75 (3 revisions) (flutter/flutter#132480)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from bcaaa0e125fe to 9cebd2015688 (2 revisions) (flutter/flutter#132477)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7915c049a1fd to bcaaa0e125fe (1 revision) (flutter/flutter#132473)
2023-08-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f47e864f2dcb to 7915c049a1fd (1 revision) (flutter/flutter#132466)
2023-08-13 chillers@google.com Revert "Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding and update default horizontal padding for Material 3" (flutter/flutter#132457)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ccdf826 PaginatedDataTable improvements (flutter/flutter#131374)
db74132
@Hixie Hixie deleted the paginateddatatable1 branch November 29, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie @HansMuller