Skip to content

Add Expanded/Collapsed State for Semantics #131233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 9 commits into from
Jul 31, 2023
Merged

Add Expanded/Collapsed State for Semantics #131233

QuncCccccc merged 9 commits into from
Jul 31, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jul 25, 2023 •
edited
Loading

This PR is to add Semantics.expanded property and apply it to submenu buttons so that the screen reader can read the status of submenus properly.

Test failures are expected because we need to merge the engine change firstly. Merging order should be:
#131359
flutter/engine#43983
and this PR.

Related to #127617.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jul 25, 2023
@QuncCccccc QuncCccccc force-pushed the add_expanded_for_semantics branch from 4c7e122 to d1aa7b0 Compare July 26, 2023 02:46
@github-actions github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Jul 26, 2023
@QuncCccccc QuncCccccc changed the title [WIP]Add Expanded/Collapsed State for Semantics Add Expanded/Collapsed State for Semantics Jul 26, 2023
@QuncCccccc QuncCccccc force-pushed the add_expanded_for_semantics branch from 107a9dc to 3d7d1bc Compare July 26, 2023 21:35
@QuncCccccc QuncCccccc requested a review from chunhtai July 26, 2023 21:38
@QuncCccccc QuncCccccc marked this pull request as ready for review July 26, 2023 21:38
@QuncCccccc QuncCccccc requested a review from gspencergoog July 26, 2023 21:39
chunhtai
chunhtai approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc force-pushed the add_expanded_for_semantics branch 4 times, most recently from fcab7be to 34187a4 Compare July 28, 2023 07:38
@QuncCccccc QuncCccccc force-pushed the add_expanded_for_semantics branch from ec64079 to 091f8bc Compare July 31, 2023 17:15
@QuncCccccc QuncCccccc merged commit 71d96dd into flutter:master Jul 31, 2023
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@QuncCccccc @LouiseHsu
Add Expanded/Collapsed State for Semantics (flutter#131233)
49a0797
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll
71d96dd Add Expanded/Collapsed State for Semantics (flutter/flutter#1…
09172f6 
…31233)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 1, 2023
@engine-flutter-autoroll
Manual roll Flutter from 1d44fbd to 1d59196 (18 revisions) (#4621)
3dc00c1 
Manual roll requested by tarrinneal@google.com

flutter/flutter@1d44fbd...1d59196

2023-07-31 maity.sumitbikram@gmail.com Appended period remove & Uri parsing fix. (flutter/flutter#131293)
2023-07-31 31812582+thisisjaymehta@users.noreply.github.com Fixed regex to show missing assets file error (flutter/flutter#131160)
2023-07-31 36861262+QuncCccccc@users.noreply.github.com Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (flutter/flutter#131363)
2023-07-31 jacksongardner@google.com Reland --omit-type-checks for benchmarks. (flutter/flutter#131493)
2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/flutter#131624)
2023-07-31 36861262+QuncCccccc@users.noreply.github.com Add Expanded/Collapsed State for Semantics (flutter/flutter#131233)
2023-07-31 36861262+QuncCccccc@users.noreply.github.com Reland - "Update Unit Tests for M2/M3" (flutter/flutter#131504)
2023-07-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (flutter/flutter#131614)
2023-07-31 34871572+gmackall@users.noreply.github.com Upgrade compile and target sdk versions in tests and benchmarks (flutter/flutter#131428)
2023-07-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (flutter/flutter#131611)
2023-07-31 engine-flutter-autoroll@skia.org Roll Packages from 10aab44 to 60e9a54 (6 revisions) (flutter/flutter#131607)
2023-07-31 6655696+guidezpl@users.noreply.github.com Fix dartdoc for `ButtonSegment` constructor (flutter/flutter#131400)
2023-07-31 danny@tuppeny.com [flutter_tools/dap] Improve rendering of structured errors via DAP (flutter/flutter#131251)
2023-07-31 dacoharkes@google.com [doc] Fix module_test_ios comments (flutter/flutter#131470)
2023-07-31 temeddix@gmail.com Use Flutter app project's NDK version from FFI plugin (flutter/flutter#131141)
2023-07-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (flutter/flutter#131597)
2023-07-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (flutter/flutter#131592)
2023-07-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (flutter/flutter#131585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@QuncCccccc @vashworth
Add Expanded/Collapsed State for Semantics (flutter#131233)
baadbe0
@HansMuller HansMuller mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @chunhtai