-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix template app documentation #131125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template app documentation #131125
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Per this comment, you will need to request a test exemption (which I'm sure will be approved): #131125 (comment) |
eliasyishak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter@dd9764e...e81907e 2023-07-28 jacksongardner@google.com Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430) 2023-07-28 tessertaha@gmail.com Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460) 2023-07-28 hans.muller@gmail.com Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447) 2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443) 2023-07-27 jonahwilliams@google.com [framework] clean up image provider documentation. (flutter/flutter#131416) 2023-07-27 39445938+DavidIsa@users.noreply.github.com Fix template app documentation (flutter/flutter#131125) 2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439) 2023-07-27 github@alexv525.com �� Add `ssh://git@github.com/flutter/flutter.git` as a standard remote (flutter/flutter#131333) 2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437) 2023-07-27 github@alexv525.com � Only format Dart files for `gen-l10n` (flutter/flutter#131232) 2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432) 2023-07-27 36861262+QuncCccccc@users.noreply.github.com Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359) 2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426) 2023-07-27 engine-flutter-autoroll@skia.org Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422) 2023-07-27 jason-simmons@users.noreply.github.com Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The PR fixes template app documentation
The PR fixes template app documentation
The PR fixes template app documentation
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.