Skip to content

[Android] Deletes deprecated splash screen meta-data element #130744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 18, 2023
Merged

[Android] Deletes deprecated splash screen meta-data element #130744

auto-submit merged 1 commit into from
Jul 18, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jul 17, 2023 •
edited
Loading

Deletes deprecated splash screen meta-data element.

This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See go/flutter-splash-screen-migration for more information.

Part of #105173.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 17, 2023
@camsim99
Copy link
Contributor Author

camsim99 commented Jul 18, 2023

This test does not have a target, but I ran it locally to confirm it passes.

@camsim99 camsim99 marked this pull request as ready for review July 18, 2023 18:19
@camsim99 camsim99 requested a review from a team July 18, 2023 18:29
reidbaker
reidbaker approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test have a target?

@camsim99
Copy link
Contributor Author

camsim99 commented Jul 18, 2023

Should this test have a target?

To clarify, I was talking about the deferred components integration test. I don't think it should have a target because it the dev directory appears to only be used for development of the framework: https://github.com/flutter/flutter/tree/master/dev#readme

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit auto-submit bot merged commit b42879a into flutter:master Jul 18, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
b42879a [Android] Deletes deprecated splash screen meta-data element (f…
b4d61f5 
…lutter/flutter#130744)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
Roll Flutter from 6f09064 to d07e8ae (60 revisions) (#4522)
dd1c9ba 
Roll Flutter from 6f09064 to d07e8ae (60 revisions)

flutter/flutter@6f09064...d07e8ae

2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09389b16d684 to eb2285205f25 (3 revisions) (flutter/flutter#130879)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0293a7cb7887 to 09389b16d684 (5 revisions) (flutter/flutter#130867)
2023-07-19 72562119+tgucio@users.noreply.github.com Move TapAndDragGestureRecognizer code under gestures (flutter/flutter#119508)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29de67c7d009 to 0293a7cb7887 (1 revision) (flutter/flutter#130858)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39d60be72ffb to 29de67c7d009 (4 revisions) (flutter/flutter#130855)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3bfc744bb61 to 39d60be72ffb (1 revision) (flutter/flutter#130847)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from adf6142f6738 to b3bfc744bb61 (7 revisions) (flutter/flutter#130843)
2023-07-18 leroux_bruno@yahoo.fr Update app_builder_test.dart for M3 (flutter/flutter#130794)
2023-07-18 ian@hixie.ch Catch errors in loadStructuredData (flutter/flutter#130748)
2023-07-18 5236035+fzyzcjy@users.noreply.github.com Fix super tiny space formatting (hope we have auto formatter in the future) (flutter/flutter#127479)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 71bbecee3010 to adf6142f6738 (2 revisions) (flutter/flutter#130831)
2023-07-18 leroux_bruno@yahoo.fr Update SnackBar tests for M2/M3 (flutter/flutter#130717)
2023-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130821)
2023-07-18 thkim1011@users.noreply.github.com Relax syntax for gen-l10n (flutter/flutter#130736)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45851af55bd6 to 71bbecee3010 (7 revisions) (flutter/flutter#130820)
2023-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130608)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 831da7e9dc3b to 45851af55bd6 (2 revisions) (flutter/flutter#130814)
2023-07-18 43054281+camsim99@users.noreply.github.com [Android] Deletes deprecated splash screen meta-data element (flutter/flutter#130744)
2023-07-18 hans.muller@gmail.com Updated `ThemeData.useMaterial3` API doc, default is `true` (flutter/flutter#130764)
2023-07-18 chillers@google.com [labeler] Mark sync-labels as empty (flutter/flutter#130642)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27658cc5ade to 831da7e9dc3b (2 revisions) (flutter/flutter#130810)
2023-07-18 engine-flutter-autoroll@skia.org Roll Packages from 6889cca to 3e8b813 (9 revisions) (flutter/flutter#130802)
2023-07-18 tessertaha@gmail.com Update `AppBar` and `AppBarTheme` tests for M2/M3 (flutter/flutter#130790)
2023-07-18 leroux_bruno@yahoo.fr Update app tests for M3 (flutter/flutter#130792)
2023-07-18 gspencergoog@users.noreply.github.com Add lint check to make sure samples are linked and have tests (flutter/flutter#130523)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from aaec42812a1f to c27658cc5ade (2 revisions) (flutter/flutter#130799)
2023-07-18 109111084+yaakovschectman@users.noreply.github.com Extract common functionality of iOS platformviews into superclasses (flutter/flutter#128716)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 88be39be7b07 to aaec42812a1f (1 revision) (flutter/flutter#130787)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b46a8baf8ed9 to 88be39be7b07 (1 revision) (flutter/flutter#130784)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777fe158f4e7 to b46a8baf8ed9 (1 revision) (flutter/flutter#130782)
2023-07-18 tessertaha@gmail.com Fix `iconTheme` in `AppBar` doesn't apply custom `Colors.white` in the dark mode for M3 (flutter/flutter#130574)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6e23288db8d to 777fe158f4e7 (2 revisions) (flutter/flutter#130779)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 116eedf769be to c6e23288db8d (3 revisions) (flutter/flutter#130778)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d018f00d687 to 116eedf769be (2 revisions) (flutter/flutter#130774)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 77ec92371846 to 9d018f00d687 (1 revision) (flutter/flutter#130772)
2023-07-18 ian@hixie.ch Document stack's clipping behaviour better (flutter/flutter#130749)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2958f9229a4 to 77ec92371846 (1 revision) (flutter/flutter#130769)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cceb705007e to f2958f9229a4 (1 revision) (flutter/flutter#130767)
2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09689d37e1d6 to 3cceb705007e (2 revisions) (flutter/flutter#130763)
2023-07-18 flar@google.com Stabilize hybrid_android_views_integration_test rendering tree (flutter/flutter#130751)
2023-07-17 andrewrkolos@gmail.com update link to good first issues (flutter/flutter#130759)
2023-07-17 31859944+LongCatIsLooong@users.noreply.github.com Prevent `InputDecorator` from supplying its descendants with non-normalized constraints (flutter/flutter#130460)
2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 15c15fd75743 to 09689d37e1d6 (3 revisions) (flutter/flutter#130758)
2023-07-17 41930132+hellohuanlin@users.noreply.github.com [tools/ios_build_ipa] fallback to CFBundleName if CFBundleDisplayName is absent (flutter/flutter#130752)
2023-07-17 goderbauer@google.com Resolve TODOs in channels integration test (flutter/flutter#130745)
2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ddbe23b374d8 to 15c15fd75743 (2 revisions) (flutter/flutter#130746)
...
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@camsim99 @LouiseHsu
[Android] Deletes deprecated splash screen meta-data element (flutter…
dee40bc 
…#130744)

Deletes deprecated splash screen meta-data element.

This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See [go/flutter-splash-screen-migration](http://go/flutter-splash-screen-migration) for more information.

Part of flutter#105173.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @reidbaker