Skip to content

Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a7 (1 revision) (#130646)" #130660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 2 commits into from
Jul 15, 2023
Merged

Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a7 (1 revision) (#130646)" #130660

zanderso merged 2 commits into from
Jul 15, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jul 15, 2023

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 15, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 15, 2023
@zanderso zanderso added warning: land on red to fix tree breakage revert Autorevert PR (with "Reason for revert:" comment) labels Jul 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 15, 2023

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jul 15, 2023
@zanderso zanderso changed the title Revert "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a7 (1 revision) (#130646)" Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a7 (1 revision) (#130646)" Jul 15, 2023
@zanderso zanderso added the revert Autorevert PR (with "Reason for revert:" comment) label Jul 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 15, 2023

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jul 15, 2023
jonahwilliams
jonahwilliams approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit f842ed9 into flutter:master Jul 15, 2023
@zanderso zanderso deleted the revert-engine branch July 15, 2023 16:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
5b92af2 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
e4150b1 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
bdd8e6c 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
f62dc01 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
86327f6 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
4abc43a 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
53ac2c8 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
5f7f082 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
bda5a25 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
d4782a8 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
5487452 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
f711840 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
15c527a 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
02a7194 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
4055c2e 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
0dee03e 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
f06e41f 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
a5acd76 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
fdda038 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f842ed9 Reverts "Roll Flutter Engine from bf6d4bfe27cc to 85af5cedf0a…
9dd22ea 
…7 (1 revision) (#130646)" (flutter/flutter#130660)
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@zanderso @LouiseHsu
Reverts "Roll Flutter Engine from bf6d4bf to 85af5ce (1 revision) (fl…
e3d0d13 
…utter#130646)" (flutter#130660)

Reverting engine rolls for test failure in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20hybrid_android_views_integration_test/8517/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jonahwilliams