Skip to content

Update DialogTheme tests for M2/M3 #130414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 14, 2023
Merged

Update DialogTheme tests for M2/M3 #130414

auto-submit merged 2 commits into from
Jul 14, 2023

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jul 12, 2023

Updated unit tests for DialogTheme to have M2 and M3 versions.

More info in #128725

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 12, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 12, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #130414 at sha 413d424ae7a7b0d62b91dabe9a9c2c9bf1afd10d

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 12, 2023
@TahaTesser
Copy link
Member Author

TahaTesser commented Jul 12, 2023

One of the golden tests needed to be duplicated for M3.

HansMuller
HansMuller reviewed Jul 12, 2023
View reviewed changes
HansMuller
HansMuller approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 12, 2023

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #130414 at sha d2480cd8460f8179f718d56f6c67ba6b07e733d5

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 13, 2023

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #130414 at sha 9b0a91bec71a6a2a0b715ced2e01d13e13990a85

@HansMuller
Copy link
Contributor

HansMuller commented Jul 13, 2023

@TahaTesser - I approved the golden file changes.

@TahaTesser
Copy link
Member Author

TahaTesser commented Jul 13, 2023

@TahaTesser - I approved the golden file changes.

Appreciate it!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@auto-submit auto-submit bot merged commit feab854 into flutter:master Jul 14, 2023
@TahaTesser TahaTesser deleted the update_dialog_theme_tests branch July 14, 2023 07:38
zanderso added a commit that referenced this pull request Jul 14, 2023
@zanderso
Revert "Update DialogTheme tests for M2/M3 (#130414)"
46ad92e 
This reverts commit feab854.
@zanderso zanderso mentioned this pull request Jul 14, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jul 14, 2023
@zanderso
Revert "Update DialogTheme tests for M2/M3" (#130578)
b8fa923 
Reverts #130414

Skia gold failures https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/11972/overview
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
8e34428
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
0b1897a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
bb6b76a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
301792c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
b8fa4fc
@TahaTesser TahaTesser mentioned this pull request Jul 17, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
e4972d1
auto-submit bot pushed a commit that referenced this pull request Jul 17, 2023
@TahaTesser
[Reland] - Update DialogTheme tests for M2/M3 (#130711)
526522d 
This relands #130414 (which was reverted in #130578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
97ce9c3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
80aa879
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
078a35a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
315cc7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
1575651
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
f8cb7b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
53833b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
c225f62
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
0ef468d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
9c01799
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
93067e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
7834dce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
b0994d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
4c247dc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
feab854 Update DialogTheme tests for M2/M3 (flutter/flutter#130414)
bac4715
@Piinks Piinks mentioned this pull request Jul 20, 2023
Closed
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@TahaTesser @LouiseHsu
Update DialogTheme tests for M2/M3 (flutter#130414)
cc90ce0 
Updated unit tests for `DialogTheme` to have M2 and M3 versions.

More info in flutter#128725
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@zanderso @LouiseHsu
Revert "Update DialogTheme tests for M2/M3" (flutter#130578)
ccbb9b7 
Reverts flutter#130414

Skia gold failures https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/11972/overview
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@TahaTesser @LouiseHsu
[Reland] - Update DialogTheme tests for M2/M3 (flutter#130711)
aae3f16 
This relands flutter#130414 (which was reverted in flutter#130578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @HansMuller