Skip to content

Setup leak tracking regression for material. #130169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 52 commits into from
Jul 22, 2023
Merged

Setup leak tracking regression for material. #130169

polina-c merged 52 commits into from
Jul 22, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Jul 7, 2023

No description provided.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: focus Focus traversal, gaining or losing focus labels Jul 7, 2023
@polina-c polina-c requested a review from goderbauer July 14, 2023 15:51
@polina-c polina-c marked this pull request as ready for review July 14, 2023 15:51
@goderbauer
Copy link
Member

goderbauer commented Jul 14, 2023

Looks like the tests are failing on this one and there's a merge conflict. Can you take a look?

@polina-c
Copy link
Contributor Author

polina-c commented Jul 15, 2023 •
edited
Loading

Looks like the tests are failing on this one and there's a merge conflict. Can you take a look?

Yes, yesterday everything was green, but then eroded. I will refresh it, but it may erode again as the PR touches many files. If you are ok with simply replacing testWidgets with testWidgetsWithLeakTracking for leak-free tests, can you LGTM, and then I will sync everything and add label autosubmit.

I promise this PR will mark only leak-free tests.

@polina-c
Copy link
Contributor Author

polina-c commented Jul 15, 2023

I ended up excluding conflicting files, because it is easier to re-cover them, than to resolve conflicts.

goderbauer
goderbauer approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 17, 2023

auto label is removed for flutter/flutter, pr: 130169, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 17, 2023

auto label is removed for flutter/flutter, pr: 130169, due to - The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions bot removed the f: focus Focus traversal, gaining or losing focus label Jul 17, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 18, 2023

auto label is removed for flutter/flutter, pr: 130169, due to - The status or check suite Windows build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 18, 2023

auto label is removed for flutter/flutter, pr: 130169, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 22, 2023

auto label is removed for flutter/flutter, pr: 130169, due to - The status or check suite Windows build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2023
@polina-c polina-c merged commit e8b397c into flutter:master Jul 22, 2023
@polina-c polina-c deleted the cover branch July 22, 2023 13:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2023
@engine-flutter-autoroll
e8b397c Setup leak tracking regression for material. (flutter/flutter…
578c153 
…#130169)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 22, 2023
@engine-flutter-autoroll
Roll Flutter from 9cfbf6b to e8b397c (12 revisions) (#4550)
e1ba65d 
flutter/flutter@9cfbf6b...e8b397c

2023-07-22 polinach@google.com Setup leak tracking regression for material. (flutter/flutter#130169)
2023-07-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6344b17a2e03 to 481684a6e276 (2 revisions) (flutter/flutter#131118)
2023-07-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b47cf14fda0e to 6344b17a2e03 (1 revision) (flutter/flutter#131114)
2023-07-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 840bcc3449ff to b47cf14fda0e (3 revisions) (flutter/flutter#131109)
2023-07-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (flutter/flutter#131101)
2023-07-21 goderbauer@google.com Remove obsolete work around for shadow drawing (flutter/flutter#131066)
2023-07-21 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from acb5d0640b6c to 2d8cff44261b (3 revisions) (flutter/flutter#131092)
2023-07-21 polinach@google.com Upgrade to newer leak_tracker. (flutter/flutter#131085)
2023-07-21 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from f5c1650c7acc to acb5d0640b6c (10 revisions) (flutter/flutter#131070)
2023-07-21 32538273+ValentinVignal@users.noreply.github.com Suggest a potential valid name for the flutter project when using `flutter create` (flutter/flutter#130900)
2023-07-21 dnfield@google.com [CI/FTL] Oriole to Panther, presubmit false (flutter/flutter#130912)
2023-07-21 6655696+guidezpl@users.noreply.github.com Improve handling of certain icons in RTL (flutter/flutter#130979)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@polina-c @LouiseHsu
Setup leak tracking regression for material. (flutter#130169)
81fc427
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@polina-c @vashworth
Setup leak tracking regression for material. (flutter#130169)
c2de7a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @goderbauer