Add a threshold when comparing screen order for selectables. #130043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
Jul 6, 2023
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
This solution seems a bit fragile. We may soon run into situation where people would require conflicting thresholds for different use cases.
Contributor
There was a problem hiding this comment.
This would likely break if there is more padding in widget span?
Contributor
There was a problem hiding this comment.
Also this should probably call vertical threshold?
Member
Author
There was a problem hiding this comment.
renamed to _kSelectableVerticalComparingThreshold
Member
Author
|
Yes, this fix is not a one-and-done solution, but I don't think this fix will make things worse. in #111021 and #127942, both cases the widgetspan just shifted like 0.5 pixel. This fix can resolve some existing issues. A final solution will probably be exposing compareOrder function to developers and we can follow up if there are more requests. |
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
I think this change is reasonable if it doesn't break any current screen order calculations. I've experienced this problem where the rects are off by a few pixels so they do not defer to horizontal comparison.
chunhtai
approved these changes
Jul 7, 2023
Contributor
There was a problem hiding this comment.
Can you add a comment explaining the situation why this is needed
Contributor
|
auto label is removed for flutter/flutter, pr: 130043, due to - The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Update selectable_region.dart Update selectable_region.dart Update selectable_region_test.dart test
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 8, 2023
flutter/flutter@d55a7d8...65ff3cb 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69eb8275ce47 to 189f823e7b41 (1 revision) (flutter/flutter#130201) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5a35b4650b1 to 69eb8275ce47 (1 revision) (flutter/flutter#130199) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9006633571bb to d5a35b4650b1 (1 revision) (flutter/flutter#130197) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ca619166c4a to 9006633571bb (2 revisions) (flutter/flutter#130195) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13d9d84e8aba to 4ca619166c4a (2 revisions) (flutter/flutter#130191) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40a8732a5de0 to 13d9d84e8aba (2 revisions) (flutter/flutter#130189) 2023-07-08 cychiang0823@gmail.com fix: duplicated Intellij IDE message when running flutter doctor (flutter/flutter#129030) 2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unneeded configuration file (flutter/flutter#130183) 2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 893ab3bf7bb9 to 40a8732a5de0 (1 revision) (flutter/flutter#130186) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b39e6fe4b3bf to 893ab3bf7bb9 (1 revision) (flutter/flutter#130180) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c83ea3e8542 to b39e6fe4b3bf (1 revision) (flutter/flutter#130176) 2023-07-07 jhy03261997@gmail.com Add a threshold when comparing screen order for selectables. (flutter/flutter#130043) 2023-07-07 aam@google.com Upgrade framework pub dependencies, roll engine with rolled dart sdk (flutter/flutter#130163) 2023-07-07 jesus_sguerrero@hotmail.com Revert "[a11y] CupertinoSwitch On/Off labels" (flutter/flutter#130166) 2023-07-07 polinach@google.com Test that inspector does not hold objects. (flutter/flutter#130102) 2023-07-07 caiquer.eds@gmail.com Fix XCode download link (flutter/flutter#129795) 2023-07-07 engine-flutter-autoroll@skia.org Roll Packages from 9bcf4bf to b61eea1 (1 revision) (flutter/flutter#130154) 2023-07-07 cbobbe@zulip.com (Raw)Autocomplete: Add optional [optionsViewOpenDirection] param (flutter/flutter#129802) 2023-07-07 5236035+fzyzcjy@users.noreply.github.com Tiny one space formatting fix (flutter/flutter#130053) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aa2e6516af1 to 5ae09b8b4fa3 (7 revisions) (flutter/flutter#130150) 2023-07-07 15619084+vashworth@users.noreply.github.com Add debugging for iOS startup test flakes (flutter/flutter#130099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a threshold when comparing screen order for selectables. So when the vertical position diff is within the threshold, will compare the horizontal position.
This fixes #111021 and #127942
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.