`DropdownMenu` can be expanded to its parent size #129753

QuncCccccc · 2023-06-29T06:15:10Z

This PR is to add a new property expandedInsets so that the DropdownMenu can be expandable and has some margins around.

Example: Setting `expandedInsets` to `EdgeInsets.zero`

import 'package:flutter/material.dart';

void main() => runApp(const DropdownMenuExample());

class DropdownMenuExample extends StatefulWidget {
  const DropdownMenuExample({super.key});

  @override
  State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}

class _DropdownMenuExampleState extends State<DropdownMenuExample> {
  final TextEditingController colorController = TextEditingController();
  ColorLabel? selectedColor;

  @override
  Widget build(BuildContext context) {
    final List<DropdownMenuEntry<ColorLabel>> colorEntries = <DropdownMenuEntry<ColorLabel>>[];
    for (final ColorLabel color in ColorLabel.values) {
      colorEntries.add(
        DropdownMenuEntry<ColorLabel>(value: color, label: color.label, enabled: color.label != 'Grey'),
      );
    }

    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        colorSchemeSeed: Colors.green,
      ),
      home: Scaffold(
        body: Center(
          child: Container(
            width: 500,
            height: 500,
            color: Colors.orange,
            child: DropdownMenu<ColorLabel>(
              expandedInsets: EdgeInsets.zero,
              inputDecorationTheme: const InputDecorationTheme(
                filled: true,
                fillColor: Colors.white,
                border: OutlineInputBorder(),
              ),
              controller: colorController,
              dropdownMenuEntries: colorEntries,
              onSelected: (ColorLabel? color) {
                setState(() {
                  selectedColor = color;
                });
              },
              // expandedInsets: EdgeInsets.only(left: 35.0, right: 20.0, top: 80),
            ),
          ),
        ),
      ),
    );
  }
}

enum ColorLabel {
  blue('Blue', Colors.blue),
  pink('Pink', Colors.pink),
  green('Green', Colors.green),
  yellow('Yellow', Colors.yellow),
  grey('Grey', Colors.grey);

  const ColorLabel(this.label, this.color);
  final String label;
  final Color color;
}

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

HansMuller

Just some feedback about the API doc

packages/flutter/lib/src/material/dropdown_menu.dart

HansMuller · 2023-07-06T16:20:54Z

packages/flutter/lib/src/material/dropdown_menu.dart

+  /// will be expanded to its parent size. The values of [expandedInsets] are
+  /// margins for the text field. In other words, If this is [EdgeInsets.zero],
+  /// the width of the text field will be the same as its parent's width.
+  ///


Just to make sure that it's clear; could add one more statement:

The [expandedInsets]' top and bottom are ignored, only its left and right properties are used.

I see. Thanks for helping review this! Just updated!

packages/flutter/lib/src/material/dropdown_menu.dart

HansMuller

I made a few more tweaks to the API doc

packages/flutter/lib/src/material/dropdown_menu.dart

…utter#129753)

Roll Flutter from 3ec96a8 to 544d30d (66 revisions) flutter/flutter@3ec96a8...544d30d 2023-07-12 engine-flutter-autoroll@skia.org Roll Packages from 188a846 to 2508714 (14 revisions) (flutter/flutter#130418) 2023-07-12 tessertaha@gmail.com Update `RadioListTile` tests format for M2/M3 (flutter/flutter#130391) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d68ea304eeda to 5c887028810d (2 revisions) (flutter/flutter#130413) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7317a58466e to d68ea304eeda (1 revision) (flutter/flutter#130410) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3dbe7dbeb5d4 to c7317a58466e (1 revision) (flutter/flutter#130402) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73093fdd77c3 to 3dbe7dbeb5d4 (1 revision) (flutter/flutter#130399) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29c5c41eeb19 to 73093fdd77c3 (2 revisions) (flutter/flutter#130398) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3482e05776a7 to 29c5c41eeb19 (1 revision) (flutter/flutter#130393) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7de68c62742d to 3482e05776a7 (2 revisions) (flutter/flutter#130390) 2023-07-12 104349824+huycozy@users.noreply.github.com Make new issue template for 1P package (flutter/flutter#130065) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b44d7ee1a60 to 7de68c62742d (4 revisions) (flutter/flutter#130384) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from e109a3c0c347 to 1b44d7ee1a60 (3 revisions) (flutter/flutter#130380) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d00590fde18c to e109a3c0c347 (1 revision) (flutter/flutter#130371) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 875d87e02276 to d00590fde18c (5 revisions) (flutter/flutter#130369) 2023-07-12 polinach@google.com Enable not GCed leak tracking. (flutter/flutter#130159) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2df01610fb3 to 875d87e02276 (3 revisions) (flutter/flutter#130359) 2023-07-11 cbobbe@zulip.com autocomplete: Remove mistaken paragraph in `onSelected` doc (flutter/flutter#130190) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59f234645dd2 to e2df01610fb3 (3 revisions) (flutter/flutter#130357) 2023-07-11 thkim1011@users.noreply.github.com Refactor refresh_indicator.1.dart to not use shrinkwrap (flutter/flutter#129377) 2023-07-11 info@ttanimichi.com Links in `material` library docs are outdated (flutter/flutter#129891) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from afee1db31e5e to 59f234645dd2 (2 revisions) (flutter/flutter#130352) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75ada1bdf9fd to afee1db31e5e (1 revision) (flutter/flutter#130349) 2023-07-11 polinach@google.com Upgrade leak_tracker to 7.0.6. (flutter/flutter#130346) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0011db79d41f to 75ada1bdf9fd (2 revisions) (flutter/flutter#130345) 2023-07-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130289) 2023-07-11 36861262+QuncCccccc@users.noreply.github.com `DropdownMenu` can be expanded to its parent size (flutter/flutter#129753) 2023-07-11 engine-flutter-autoroll@skia.org Roll Packages from 4469c5e to 188a846 (6 revisions) (flutter/flutter#130340) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d75c70870f86 to 0011db79d41f (2 revisions) (flutter/flutter#130337) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e9f0d61a42a to d75c70870f86 (1 revision) (flutter/flutter#130332) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) (flutter/flutter#130330) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) (flutter/flutter#130324) 2023-07-11 tessertaha@gmail.com Add `Badge` widget to `NavigationBar` and `NavigationRail` examples (flutter/flutter#129834) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) (flutter/flutter#130321) 2023-07-11 ian@hixie.ch Update labeler for recent changes (flutter/flutter#130168) 2023-07-11 hey@darshanrander.com fix: `ExpansionTileTheme.shape` assignment in `ExpansionTile` (flutter/flutter#127749) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) (flutter/flutter#130316) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) (flutter/flutter#130315) 2023-07-11 ian@hixie.ch Implement preferPaintInterior correctly for _CompoundBorder (flutter/flutter#129851) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) (flutter/flutter#130313) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) (flutter/flutter#130311) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 312e4813a880 to 2c82dd7ec54b (1 revision) (flutter/flutter#130309) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95316fbc25a7 to 312e4813a880 (2 revisions) (flutter/flutter#130307) 2023-07-11 robert.ancell@canonical.com Add Linux implementation of the platform view example (flutter/flutter#123731) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from daecd616f5a7 to 95316fbc25a7 (4 revisions) (flutter/flutter#130305) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a0dd9d2f28e to daecd616f5a7 (3 revisions) (flutter/flutter#130298) 2023-07-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d054abf842c to 2a0dd9d2f28e (4 revisions) (flutter/flutter#130296) ...

QuncCccccc changed the title ~~Add expanded feature~~ DropdownMenu can be expanded to its parent size Jun 29, 2023

QuncCccccc force-pushed the add_expanded_feature branch from 8f6af01 to 0f8e29a Compare June 29, 2023 22:14

github-actions bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 29, 2023

QuncCccccc added 6 commits July 5, 2023 16:57

Add isExpanded property

5b77ca4

Update fix and test

8fb3e4d

Update fix

231f751

Update test

fbb9f9d

Update documentation

d9f9079

Update

f18bd2f

QuncCccccc force-pushed the add_expanded_feature branch from bcda162 to f18bd2f Compare July 5, 2023 23:57

Add a comment

b6572d3

QuncCccccc requested a review from HansMuller July 6, 2023 05:56

QuncCccccc marked this pull request as ready for review July 6, 2023 05:56

HansMuller reviewed Jul 6, 2023

View reviewed changes

Address pr comments

5e7fcc6

HansMuller approved these changes Jul 11, 2023

View reviewed changes

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

HansMuller added 4 commits July 11, 2023 08:41

Update packages/flutter/lib/src/material/dropdown_menu.dart

86bc29e

Update packages/flutter/lib/src/material/dropdown_menu.dart

01213d7

Update packages/flutter/lib/src/material/dropdown_menu.dart

f57f816

Merge branch 'master' into add_expanded_feature

8e3426b

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2023

auto-submit bot merged commit 12acff8 into master Jul 11, 2023

auto-submit bot deleted the add_expanded_feature branch July 11, 2023 17:08

engine-flutter-autoroll mentioned this pull request Jul 12, 2023

Roll Flutter from 3ec96a8a4a5d to 21e3bb89676c (65 revisions) flutter/packages#4447

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023

12acff8 DropdownMenu can be expanded to its parent size (flutter/fl…

e634775

…utter#129753)

engine-flutter-autoroll mentioned this pull request Jul 12, 2023

Roll Flutter from 3ec96a8a4a5d to 544d30dbaddf (66 revisions) flutter/packages#4448

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023

12acff8 DropdownMenu can be expanded to its parent size (flutter/fl…

077335e

…utter#129753)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Jannik-dev mentioned this pull request Oct 17, 2023

DropdownMenu The named parameter 'expandedInsets' isn't defined #136759

Closed

2 tasks

Sladamos mentioned this pull request Mar 1, 2024

Slema 159 pikol93/PG_SLEMA#46

Merged

TahaTesser mentioned this pull request Oct 4, 2024

Fix DropdownMenu with expandedInsets always aligned on top #156214

Merged

9 tasks

blendthink mentioned this pull request Oct 23, 2024

[Improve]: DropdownMenu.expandInsets を利用して親の横幅に合わせられるようにする yumemi-inc/flutter-mobile-project-template#331

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`DropdownMenu` can be expanded to its parent size #129753

`DropdownMenu` can be expanded to its parent size #129753

Uh oh!

QuncCccccc commented Jun 29, 2023 •

edited

Loading

Uh oh!

HansMuller left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller Jul 6, 2023

Uh oh!

QuncCccccc Jul 11, 2023

Uh oh!

Uh oh!

HansMuller left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DropdownMenu can be expanded to its parent size #129753

DropdownMenu can be expanded to its parent size #129753

Uh oh!

Conversation

QuncCccccc commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`DropdownMenu` can be expanded to its parent size #129753

`DropdownMenu` can be expanded to its parent size #129753

QuncCccccc commented Jun 29, 2023 •

edited

Loading