Fix `NavigationDrawer` selected item has wrong icon color #129625

TahaTesser · 2023-06-27T12:17:32Z

fixes NavigationDrawer selected item has wrong icon color [Material3 spec]

Description

This PR fixes a mistake in the NavigationDrawer defaults, where generated token value returns a null.
This issue can be detected when you want to customize the selected icon color for NavigationDrawerDestination using a custom color scheme.

Code sample

expanded to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      themeMode: ThemeMode.light,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith(
          onSecondaryContainer: Colors.red,
        ),
        useMaterial3: true,
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('NavigationDrawer Sample'),
      ),
      drawer: const NavigationDrawer(
        children: <Widget>[
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
            selectedIcon: Icon(Icons.favorite_rounded),
          ),
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
          ),
        ],
      ),
    );
  }
}

Before

After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hannah-hyj

LGTM

…utter/flutter#129625)

flutter/flutter@ff838bc...aa5f4a2 2023-07-01 goderbauer@google.com Enable no_wildcard_variable_uses lint (flutter/flutter#129858) 2023-06-30 christopherfujino@gmail.com mark packages-autoroller bringup again (flutter/flutter#129859) 2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchTheme` tests for M2/M3 (flutter/flutter#129811) 2023-06-30 christopherfujino@gmail.com Change pub roller bot to push to flutter-pub-roller-bot/flutter.git (flutter/flutter#129844) 2023-06-30 greg@zulip.com Fix NetworkImage causing spurious warning in tests (flutter/flutter#129537) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) (flutter/flutter#129852) 2023-06-30 34871572+gmackall@users.noreply.github.com Upgrade integration tests to use AGP 7.3/Gradle 7.4 (flutter/flutter#129642) 2023-06-30 engine-flutter-autoroll@skia.org Roll Packages from d4752c4 to 53ed5a0 (5 revisions) (flutter/flutter#129837) 2023-06-30 32242716+ricardoamador@users.noreply.github.com Updated correct tasks for test ownership fix (flutter/flutter#129812) 2023-06-30 hans.muller@gmail.com Updated some golden image tests for M2/M3 (flutter/flutter#129794) 2023-06-30 nbosch@google.com Remove an unnecessary assert (flutter/flutter#129796) 2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Radio` tests for M2/M3 (flutter/flutter#129814) 2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Switch` tests for M2/M3 (flutter/flutter#129810) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (flutter/flutter#129821) 2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchListTile` tests for M2/M3 (flutter/flutter#129809) 2023-06-30 tessertaha@gmail.com Fix `NavigationDrawer` selected item has wrong icon color (flutter/flutter#129625) 2023-06-30 leroux_bruno@yahoo.fr Update basic_test.dart for M3 compliance (flutter/flutter#129714) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (flutter/flutter#129818) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (flutter/flutter#129801) 2023-06-30 godofredoc@google.com Revert no-response to fork. (flutter/flutter#129775) 2023-06-30 36861262+QuncCccccc@users.noreply.github.com Make `DropdownMenu` be able to scroll to the highlighted item when searching. (flutter/flutter#129740) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (flutter/flutter#129799) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/flutter#129797) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (flutter/flutter#129756) 2023-06-29 5236035+fzyzcjy@users.noreply.github.com Remove `@NonNull` to avoid warning (flutter/flutter#129472) 2023-06-29 32242716+ricardoamador@users.noreply.github.com Remove use of any (flutter/flutter#129793) 2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/flutter#129769) 2023-06-29 lsaudon@gmail.com Deletes files that should be ignored (flutter/flutter#127984) 2023-06-29 christopherfujino@gmail.com Fix flutter_plugins by rolling revision (flutter/flutter#129781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter/flutter#129625)

HansMuller requested a review from hannah-hyj June 28, 2023 19:05

hannah-hyj approved these changes Jun 28, 2023

View reviewed changes

TahaTesser added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 28, 2023

github-actions bot removed f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 28, 2023

Fix NavigationDrawer selected item has wrong icon color

4da6ce0

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2023

auto-submit bot merged commit 7cef966 into flutter:master Jun 30, 2023

TahaTesser deleted the navigation_drawer_icon_color branch June 30, 2023 09:00

HansMuller mentioned this pull request Jun 30, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Jul 1, 2023

Roll Flutter from ff838bca8990 to aa5f4a28e9a8 (29 revisions) flutter/packages#4363

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2023

7cef966 Fix NavigationDrawer selected item has wrong icon color (fl…

33aa6ee

…utter/flutter#129625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

7cef966 Fix NavigationDrawer selected item has wrong icon color (fl…

46188f7

…utter/flutter#129625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7cef966 Fix NavigationDrawer selected item has wrong icon color (fl…

63d5078

…utter/flutter#129625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7cef966 Fix NavigationDrawer selected item has wrong icon color (fl…

4503296

…utter/flutter#129625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7cef966 Fix NavigationDrawer selected item has wrong icon color (fl…

fdccaa7

…utter/flutter#129625)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `NavigationDrawer` selected item has wrong icon color #129625

Fix `NavigationDrawer` selected item has wrong icon color #129625

Uh oh!

TahaTesser commented Jun 27, 2023

Uh oh!

hannah-hyj left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix NavigationDrawer selected item has wrong icon color #129625

Fix NavigationDrawer selected item has wrong icon color #129625

Uh oh!

Conversation

TahaTesser commented Jun 27, 2023

Description

Code sample

Before

After

Pre-launch Checklist

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix `NavigationDrawer` selected item has wrong icon color #129625

Fix `NavigationDrawer` selected item has wrong icon color #129625