Shared state to support multi screen inspection #129452

CoderDake · 2023-06-23T21:52:02Z

With Multi View applications on the way, we need to be able to manage the state of multiple Inspector widgets in a consistent way.

Previously each Widget inspector would manage the state of it's own inspection. This made for a confusing and inconsistent experience when clicking on the widget inspector of different views.

This PR changes the state management to the WidgetInspectorService static instance so that all widget inspectors can share that state.

Demo

Screen.Recording.2023-07-10.at.4.26.37.PM2.mov

packages/flutter/lib/src/widgets/widget_inspector.dart

jacob314

Overall looks like it is on the right track.

packages/flutter/lib/src/widgets/widget_inspector.dart

wanjm · 2023-07-15T06:16:58Z

where can i get the multi window example in the above video;

CoderDake · 2023-07-17T17:10:25Z

@wanjm It can be found here:
https://github.com/goderbauer/mvp

packages/flutter/lib/src/widgets/widget_inspector.dart

CoderDake · 2023-07-21T20:34:07Z

Fixes flutter/devtools#5935

CoderDake · 2023-07-21T20:41:55Z

Fixes flutter/devtools#5931

packages/flutter/lib/src/widgets/widget_inspector.dart

jacob314 · 2023-07-27T21:16:49Z

packages/flutter/lib/src/widgets/widget_inspector.dart

-    final double maxWidth = size.width - 2 * (_kScreenEdgeMargin + _kTooltipPadding);
+    final double maxWidth = math.max(
+      size.width - 2 * (_kScreenEdgeMargin + _kTooltipPadding),
+      0,


good catch! should we just short circuit and not try to draw anything is maxWidth <= 0?

Perhaps we could but I don't know enough about these cases to know if we always want to.

packages/flutter/lib/src/widgets/widget_inspector.dart

jacob314

LGTM once these small nits are resolved.

…o multi-screen-inspection-state

goderbauer

LGTM

packages/flutter/test/widgets/widget_inspector_test.dart

jacob314

…ter#129452)

flutter/flutter@e81907e...c2b40ca 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 24ccd8fffbcb to 5184062f7543 (2 revisions) (flutter/flutter#131554) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90bc483524fe to 24ccd8fffbcb (1 revision) (flutter/flutter#131540) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27128f29a066 to 90bc483524fe (2 revisions) (flutter/flutter#131535) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69b5b77edaf7 to 27128f29a066 (1 revision) (flutter/flutter#131533) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b854fdea2715 to 69b5b77edaf7 (1 revision) (flutter/flutter#131532) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a5b2f521539 to b854fdea2715 (1 revision) (flutter/flutter#131530) 2023-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.0 to 2.21.2 (flutter/flutter#131512) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5c17f0e2406 to 0a5b2f521539 (2 revisions) (flutter/flutter#131529) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4bf592279d6 to f5c17f0e2406 (1 revision) (flutter/flutter#131525) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from da3721adba65 to b4bf592279d6 (2 revisions) (flutter/flutter#131519) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa1278eb7b84 to da3721adba65 (5 revisions) (flutter/flutter#131514) 2023-07-28 leroux_bruno@yahoo.fr Reland - Fix floating SnackBar throws when FAB is on the top (flutter/flutter#131475) 2023-07-28 ian@hixie.ch Device discovery output cleanup (flutter/flutter#131223) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 182e1189873b to aa1278eb7b84 (2 revisions) (flutter/flutter#131500) 2023-07-28 tessertaha@gmail.com Update `BottomSheet.enableDrag` & `BottomSheet.showDragHandle` docs for animation controller (flutter/flutter#131484) 2023-07-28 36861262+QuncCccccc@users.noreply.github.com Deprecate `useMaterial3` parameter in `ThemeData.copyWith()` (flutter/flutter#131455) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73615d66b2fe to 182e1189873b (2 revisions) (flutter/flutter#131492) 2023-07-28 tessertaha@gmail.com Add `CheckedPopupMenuItemâ��.labelTextStyle` and update default text style for Material 3 (flutter/flutter#131060) 2023-07-28 ychris@google.com Remove obsolete `complex_layout_ios__compile.dart` test (flutter/flutter#131487) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from e97014c71014 to 73615d66b2fe (3 revisions) (flutter/flutter#131485) 2023-07-28 chevalier.dan@gmail.com Shared state to support multi screen inspection (flutter/flutter#129452) 2023-07-28 engine-flutter-autoroll@skia.org Roll Packages from f4ae933 to 10aab44 (4 revisions) (flutter/flutter#131483) 2023-07-28 ychris@google.com Move ios_app_with_extensions_test to host only (flutter/flutter#131441) 2023-07-28 tessertaha@gmail.com Update `Card.color` documentation for Material 3 (flutter/flutter#131468) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

![](https://media.giphy.com/media/KY2dtJNlGPH08w41FN/giphy.gif) Fixes flutter/devtools#5931 With Multi View applications on the way, we need to be able to manage the state of multiple Inspector widgets in a consistent way. Previously each Widget inspector would manage the state of it's own inspection. This made for a confusing and inconsistent experience when clicking on the widget inspector of different views. This PR changes the state management to the WidgetInspectorService static instance so that all widget inspectors can share that state. # Demo https://github.com/flutter/flutter/assets/1386322/70fd18dc-5827-4dcd-8cb7-ef20e6221291

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 23, 2023

CoderDake changed the title ~~Multi screen inspection state~~ Shared state to support multi screen inspection Jun 23, 2023

CoderDake marked this pull request as ready for review July 11, 2023 14:31

CoderDake requested review from goderbauer and jacob314 July 11, 2023 14:31

jacob314 reviewed Jul 11, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 11, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 11, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 11, 2023

View reviewed changes

goderbauer reviewed Jul 11, 2023

View reviewed changes

goderbauer reviewed Jul 14, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 17, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Jul 26, 2023

Pulling just my changes from my branch change

fa66401

CoderDake force-pushed the multi-screen-inspection-state branch from 78adb4b to fa66401 Compare July 26, 2023 21:03

CoderDake added 3 commits July 27, 2023 09:13

lint cleanup

d694629

cleanup :D

09da8d8

Merge branch 'master' into multi-screen-inspection-state

ef98232

jacob314 reviewed Jul 27, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Show resolved Hide resolved

jacob314 reviewed Jul 27, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 27, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 27, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

jacob314 reviewed Jul 27, 2023

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Show resolved Hide resolved

jacob314 reviewed Jul 27, 2023

View reviewed changes

CoderDake added 2 commits July 27, 2023 18:41

Jacob nits

0bdb4bc

Merge remote-tracking branch 'dake/multi-screen-inspection-state' int…

ba27104

…o multi-screen-inspection-state

goderbauer approved these changes Jul 27, 2023

View reviewed changes

jacob314 approved these changes Jul 27, 2023

View reviewed changes

Goderbaeur feedback

3595efd

CoderDake merged commit f0163c0 into flutter:master Jul 28, 2023

HansMuller mentioned this pull request Jul 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Jul 29, 2023

Roll Flutter from e81907e07a38 to e94e185c364c (23 revisions) flutter/packages#4585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2023

f0163c0 Shared state to support multi screen inspection (flutter/flut…

a37499c

…ter#129452)

engine-flutter-autoroll mentioned this pull request Jul 29, 2023

Roll Flutter from e81907e07a38 to c2b40ca7013b (24 revisions) flutter/packages#4588

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2023

f0163c0 Shared state to support multi screen inspection (flutter/flut…

ec11921

…ter#129452)

CoderDake mentioned this pull request Aug 2, 2023

Widget Inspector Selection broken in Multi View App flutter/devtools#5932

Closed

Shared state to support multi screen inspection #129452

Shared state to support multi screen inspection #129452

Uh oh!

Conversation

CoderDake commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wanjm commented Jul 15, 2023

Uh oh!

CoderDake commented Jul 17, 2023

Uh oh!

Uh oh!

CoderDake commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CoderDake commented Jul 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacob314 Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

CoderDake Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CoderDake commented Jun 23, 2023 •

edited

Loading

CoderDake commented Jul 21, 2023 •

edited

Loading