Updated TextMagnifierExampleApp to M3 #129381
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
de0e4a7 to
aabe91f
Compare
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Or are we supposed to test stuff like this? 🤔
|
There's a golden image that should be updated as part of this PR. I'm assuming that eventually the presubmit will ask me to approve the new golden image. |
|
So I would have expected the API docs tests to have run and there would be an image at https://flutter-gold.skia.org/changelists in spite of the bot, but there is none. It looks like the API docs tests just did not run for this PR (filed #129390), in addition to the bot not noticing this was a PR that should be checked for golden file images (filed #129389). So much discovery for one tiny PR! 🕵️ |
|
Issues in last comment should be resolved by #129433 and flutter/cocoon#2860 Once those land and deploy, a rebase here should have this all fixed up. :) |
aabe91f to
10769fa
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Roll Flutter from 042c036 to 96a2c05 (60 revisions) flutter/flutter@042c036...96a2c05 2023-06-26 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/flutter#129453) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 63582320d20e to 4032a9bc964e (2 revisions) (flutter/flutter#129569) 2023-06-26 hans.muller@gmail.com Updated TextMagnifierExampleApp to M3 (flutter/flutter#129381) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (flutter/flutter#129563) 2023-06-26 tessertaha@gmail.com Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding (flutter/flutter#129556) 2023-06-26 godofredoc@google.com Process only specific labels. (flutter/flutter#129475) 2023-06-26 engine-flutter-autoroll@skia.org Roll Packages from d041934 to 6b70804 (7 revisions) (flutter/flutter#129559) 2023-06-26 ian@hixie.ch Make bug templates more consistent (flutter/flutter#129460) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (flutter/flutter#129544) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (flutter/flutter#129540) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (flutter/flutter#129534) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (flutter/flutter#129531) 2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (flutter/flutter#129514) 2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (flutter/flutter#129508) 2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (flutter/flutter#129498) 2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (flutter/flutter#129495) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (flutter/flutter#129493) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (flutter/flutter#129489) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (flutter/flutter#129487) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (flutter/flutter#129483) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (flutter/flutter#129479) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (flutter/flutter#129476) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (flutter/flutter#129474) 2023-06-24 godofredoc@google.com Fix issues with no response bot. (flutter/flutter#129470) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (flutter/flutter#129473) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (flutter/flutter#129468) 2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (flutter/flutter#129466) 2023-06-24 bdero@google.com [devicelab] Add platform view scroll benchmarks for Impeller on Android (flutter/flutter#129455) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (flutter/flutter#129456) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (flutter/flutter#129451) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (flutter/flutter#129445) 2023-06-23 737941+loic-sharma@users.noreply.github.com Add CallbackShortcuts widget of the week video (flutter/flutter#129296) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (flutter/flutter#129444) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (flutter/flutter#129440) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (flutter/flutter#129437) 2023-06-23 godofredoc@google.com Add a devicelab test to recipes cq. (flutter/flutter#129411) 2023-06-23 paurakh011@gmail.com fix: Inconsistency of SelectionArea when scrolling (flutter/flutter#128765) 2023-06-23 katelovett@google.com Run misc test shard when examples/api/** change (flutter/flutter#129433) 2023-06-23 49699333+dependabot[bot]@users.noreply.github.com Bump ubuntu from `b795f8e` to `db8bf6f` in /dev/ci/docker_linux (flutter/flutter#128740) 2023-06-23 godofredoc@google.com Add r: timeout label to bugs/pr closed by no response bot. (flutter/flutter#129408) 2023-06-23 godofredoc@google.com Remove .github/move.yml. (flutter/flutter#129409) 2023-06-23 engine-flutter-autoroll@skia.org Roll Packages from 95bc1c6 to d041934 (6 revisions) (flutter/flutter#129429) 2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from aca26b2afc27 to 27f3498286ff (16 revisions) (flutter/flutter#129421) 2023-06-23 godofredoc@google.com Add comments to .ci.yaml that were removed from recipes. (flutter/flutter#129321) 2023-06-23 godofredoc@google.com Update no response to use core action. (flutter/flutter#129405) 2023-06-23 xilaizhang@google.com Revert "[web] Migrate framework to fully use package:web" (flutter/flutter#129400) ...
All is well. The golden image change was offered up and triaged by yours truly. Thanks for the quick fix! |
This change is part of "step 3" in #127064.
Updated the TextMagnifierExampleApp to use Material3.