Refactor Analytics global getter to point to context only
#129196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
test-exempt: code refactor with no semantic change |
Contributor
|
FWIW, long term the goal as I understand it is to get rid of all global variables, including the global context, and just pass dependencies as arguments to subclasses and such. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 21, 2023
11 tasks
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 22, 2023
Manual version of #4269 ---- Roll Flutter from fc8856e to c40baf4 (57 revisions) flutter/flutter@fc8856e...c40baf4 2023-06-21 engine-flutter-autoroll@skia.org Roll Packages from 6e1918f to 0fdf05f (8 revisions) (flutter/flutter#129286) 2023-06-21 christopherfujino@gmail.com move test ownership from zanderso -> tools team (flutter/flutter#129199) 2023-06-21 42216813+eliasyishak@users.noreply.github.com Refactor `Analytics` global getter to point to context only (flutter/flutter#129196) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from cfbd3652532d to f973fb4636d3 (1 revision) (flutter/flutter#129253) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 059643dcc8e3 to cfbd3652532d (1 revision) (flutter/flutter#129243) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5313ca367549 to 059643dcc8e3 (1 revision) (flutter/flutter#129240) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 946f523859fe to 5313ca367549 (2 revisions) (flutter/flutter#129234) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5a860c5479c to 946f523859fe (2 revisions) (flutter/flutter#129232) 2023-06-21 31859944+LongCatIsLooong@users.noreply.github.com Relax `OverlayPortal` asserts (flutter/flutter#129053) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from adfc3af300a9 to e5a860c5479c (3 revisions) (flutter/flutter#129228) 2023-06-21 godofredoc@google.com Move all the firebase lab device configs to .ci.yaml. (flutter/flutter#129219) 2023-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d4abb81ccd1 to adfc3af300a9 (2 revisions) (flutter/flutter#129225) 2023-06-20 andrewrkolos@gmail.com update resolution-aware asset docs links (flutter/flutter#128769) 2023-06-20 jmccandless@google.com Fix: Magnifier appears and won't dismiss (flutter/flutter#128545) 2023-06-20 thkim1011@users.noreply.github.com DecoratedSliver (flutter/flutter#127823) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 666244148e89 to 7d4abb81ccd1 (1 revision) (flutter/flutter#129217) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06d0c08460e5 to 666244148e89 (2 revisions) (flutter/flutter#129208) 2023-06-20 yeasinsheikh50@gmail.com fixed PreferredSize constuctor invocations (flutter/flutter#128181) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c16af76ca26 to 06d0c08460e5 (3 revisions) (flutter/flutter#129200) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec64672afd91 to 1c16af76ca26 (1 revision) (flutter/flutter#129197) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4444ede34a9c to ec64672afd91 (3 revisions) (flutter/flutter#129194) 2023-06-20 15619084+vashworth@users.noreply.github.com Fix duplicate devices from xcdevice with iOS 17 (flutter/flutter#128802) 2023-06-20 ychris@google.com iOS info.plist template: make UIViewControllerBasedStatusBar to be true (flutter/flutter#128970) 2023-06-20 whesse@google.com Fix detection that tests are running on monorepo bots (flutter/flutter#129173) 2023-06-20 chingjun@google.com Use the new `getIsolatePauseEvent` method from VM service to check for pause event. (flutter/flutter#128834) 2023-06-20 31922733+SwaroopSambhayya@users.noreply.github.com Adding ScrollController support for Stepper widget (flutter/flutter#128814) 2023-06-20 engine-flutter-autoroll@skia.org Roll Packages from 59d93d6 to 6e1918f (6 revisions) (flutter/flutter#129176) 2023-06-20 thkim1011@users.noreply.github.com Refactor generate_localizations_test.dart (flutter/flutter#128974) 2023-06-20 kevinjchisholm@google.com [process] Add a design doc issue template. (flutter/flutter#128361) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd6d3fc90462 to 4444ede34a9c (1 revision) (flutter/flutter#129169) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73c4ba4240cc to bd6d3fc90462 (1 revision) (flutter/flutter#129168) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7ee874792067 to 73c4ba4240cc (1 revision) (flutter/flutter#129162) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a6c8fb591f5 to 7ee874792067 (1 revision) (flutter/flutter#129160) 2023-06-20 leigha.jarett@gmail.com Add to API docs to explain what Assist and Suggestion chips are (flutter/flutter#129034) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a91bb3f566b9 to 6a6c8fb591f5 (1 revision) (flutter/flutter#129158) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0d456d9251b to a91bb3f566b9 (1 revision) (flutter/flutter#129148) 2023-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55418e648958 to e0d456d9251b (1 revision) (flutter/flutter#129146) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 84ecaa053ec6 to 55418e648958 (1 revision) (flutter/flutter#129145) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23a2c246600f to 84ecaa053ec6 (2 revisions) (flutter/flutter#129142) 2023-06-19 tessertaha@gmail.com Introduce MaterialState `color` property for chips (flutter/flutter#128584) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 280491d4cc21 to 23a2c246600f (8 revisions) (flutter/flutter#129140) 2023-06-19 jason-simmons@users.noreply.github.com Fix an ordering dependency in the flutter_tools upgrade test (flutter/flutter#129131) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 164c6b49dfb5 to 280491d4cc21 (1 revision) (flutter/flutter#129102) 2023-06-19 tessertaha@gmail.com Fix `InputDecoration.applyDefaults` ignoring some properties (flutter/flutter#129010) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from d298f0bf720c to 164c6b49dfb5 (1 revision) (flutter/flutter#129100) 2023-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7ffa1355f718 to d298f0bf720c (24 revisions) (flutter/flutter#129092) ... ----
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the globals getter for
Analyticsto be in the context instead of having a default fallback. The current state of the tool creates a new instance every timeglobals.analyticswas calledAddresses issue:
Analyticsfrompackage:unified_analytics#128535Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.