[web] Don't crash on const HtmlElementView()
#128965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Jun 15, 2023
Member
ditman
left a comment
There was a problem hiding this comment.
LGTM, minor comment about skipping the new test when kIsWeb.
Comment on lines
+3189
to
+3190
| // This file runs on non-web platforms, so we expect `HtmlElementView` to | ||
| // fail. |
Member
There was a problem hiding this comment.
Instead of this, why not skip: kIsWeb on the test? That way we know for sure this is a non-web test only?
Contributor
Author
There was a problem hiding this comment.
The entire file is not supposed to run on web (it has @TestOn('!chrome')). I bet all tests will fail, including the new one, if we accidentally run this file on web.
The comment is just to clarify for anyone who jumps directly to this test without looking at the entire file.
Member
There was a problem hiding this comment.
Ah, if there's a @TestOn('!chrome'), ship it (!browser would be better, though, this test would attempt to run in firefox if I'm understanding this right)
Contributor
Author
There was a problem hiding this comment.
Oh interesting. Yeah we definitely need to fix that. I'll create an issue so we don't forget.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 16, 2023
flutter/flutter@b0188cd...fc8856e 2023-06-16 mdebbar@google.com [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965) 2023-06-16 engine-flutter-autoroll@skia.org Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878) 2023-06-16 polinach@google.com Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967) 2023-06-15 dery.ra@gmail.com Fix dart pub cache clean command on pub.dart (flutter/flutter#128171) 2023-06-15 christopherfujino@gmail.com [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737) 2023-06-15 christopherfujino@gmail.com [flutter_tools] refactor license collector (flutter/flutter#128748) 2023-06-15 36861262+QuncCccccc@users.noreply.github.com Set Semantics.button to true for date widget (flutter/flutter#128824) 2023-06-15 36861262+QuncCccccc@users.noreply.github.com Update golden tests (flutter/flutter#128914) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959) 2023-06-15 ian@hixie.ch flutter update-packages --cherry-pick-package (flutter/flutter#128917) 2023-06-15 christopherfujino@gmail.com add .pub-cache back to .gitignore (flutter/flutter#128894) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849) 2023-06-15 mdebbar@google.com flutter update-packages --force-upgrade (flutter/flutter#128908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the code contained
const HtmlElementView()it would break even if it's guarded byif (kIsWeb).This PR makes it such that
const HtmlElementView()is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms.One improvement we can make in the future is to have a conditional import:
_html_element_view_web.dartthat contains the realHtmlElementViewthat can only be instantiated on web._html_element_view_io.dartthat contains a stub with an unimplementedbuild()method.Fixes #43532