[flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder #128810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of AnimatedBuilder
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
@gspencergoog WDYT about this change? |
gspencergoog
approved these changes
Jul 5, 2023
Contributor
gspencergoog
left a comment
There was a problem hiding this comment.
Works for me. It is more readable as a ListenableBuilder, which is the whole point of adding that Builder widget.
Contributor
|
Because it doesn't have a test, you'll need to ask for test exemption from Hixie on Discord, as the bot's message above says. It's a refactoring with no semantic change, so it's likely to be approved. |
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 7, 2023
flutter/flutter@bc49cd1...d55a7d8 2023-07-07 hans.muller@gmail.com Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144) 2023-07-07 engine-flutter-autoroll@skia.org Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106) 2023-07-06 5236035+fzyzcjy@users.noreply.github.com Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100) 2023-07-06 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097) 2023-07-06 fluttergithubbot@gmail.com Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398) 2023-07-06 polinach@google.com Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962) 2023-07-06 82336674+gilnobrega@users.noreply.github.com [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776) 2023-07-06 henriquenas.dev@gmail.com Add option for flexible space on material SearchDelegate (flutter/flutter#128132) 2023-07-06 engine-flutter-autoroll@skia.org Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077) 2023-07-06 2539699336@qq.com [framework] Add textField OCR support for framework side (flutter/flutter#96637) 2023-07-06 37002358+fabiancrx@users.noreply.github.com [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…lder instead of AnimatedBuilder (flutter/flutter#128810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces AnimatedBuilder for ListenableBuilder in the skeleton template
Fixes #128801
No tests needed