Skip to content

[devicelab] add drawPoints benchmark #126728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 15, 2023
Merged

[devicelab] add drawPoints benchmark #126728

auto-submit merged 4 commits into from
May 15, 2023

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 13, 2023

Add a benchmark that measures the improvements from flutter/engine#41803

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 13, 2023
@jonahwilliams jonahwilliams mentioned this pull request May 13, 2023
Closed
@jonahwilliams jonahwilliams requested review from dnfield and zanderso May 15, 2023 17:22
zanderso
zanderso approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ nit

dev/benchmarks/macrobenchmarks/lib/src/draw_points.dart Outdated
canvas.drawPaint(Paint()..color = Colors.white);
for (int i = 0; i < 8; i++) {
final double x = ((size.width / i) + tick) % size.width;
for (int j = 0; j < 8000; j += 2) {
Copy link
Member

@zanderso zanderso May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000 -> data.length ?

Copy link
Contributor Author

@jonahwilliams jonahwilliams May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit 41abe99 into flutter:master May 15, 2023
@jonahwilliams jonahwilliams mentioned this pull request May 15, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
d185de7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
b151146
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
9ddb879
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
3d422b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
99cf3f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
c15abef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
235b790
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
2db404e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
8530fc6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
36cf8f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
96cd538
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
7f07079
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
de109dc
auto-submit bot pushed a commit to flutter/engine that referenced this pull request May 19, 2023
[Impeller] Fix 1d threadgroup dispatch size, Implement drawPoint geom…
0166141 
…etry computation with compute, fallback to specialized CPU. (#42060)

Compute shader implementation of #41803

I found this to be generally more straightforward, and we can revisit the vertex shader approach with GLES.

Benchmark is pending here: flutter/flutter#126728

Note: rendering behavior is identical even though this is now a single draw call. This is becuase strokes have overdraw prevention enabled by default, while this new contents does not

![image](https://github.com/flutter/engine/assets/8975114/29d84e0d-7be6-426a-b5e3-5226c1953a47)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
[devicelab] add drawPoints benchmark (flutter#126728)
a93c7d7 
Add a benchmark that measures the improvements from flutter/engine#41803
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
0e64836
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
b1c0d1f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
69efb70
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
41abe99 [devicelab] add drawPoints benchmark (flutter/flutter#126728)
9162650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @zanderso