Skip to content

Fix crash from invalid ListWheelViewport assertion#126539

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
nt4f04uNd:fix/126491/list-wheel-crash
May 13, 2023
Merged

Fix crash from invalid ListWheelViewport assertion#126539
auto-submit[bot] merged 1 commit into
flutter:masterfrom
nt4f04uNd:fix/126491/list-wheel-crash

Conversation

@nt4f04uNd

@nt4f04uNd nt4f04uNd commented May 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #126491

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@nt4f04uNd nt4f04uNd added c: regression It was better in the past than it is now c: crash Stack traces logged to the console framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. labels May 11, 2023
@nt4f04uNd nt4f04uNd requested a review from Piinks May 11, 2023 13:19
@nt4f04uNd nt4f04uNd force-pushed the fix/126491/list-wheel-crash branch from 670aaa9 to fb293b9 Compare May 11, 2023 13:22
@nt4f04uNd nt4f04uNd force-pushed the fix/126491/list-wheel-crash branch from fb293b9 to 2568dbd Compare May 11, 2023 14:12
Piinks
Piinks approved these changes May 12, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thanks for the fix!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@Piinks

Piinks commented May 12, 2023

Copy link
Copy Markdown
Contributor

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

@nt4f04uNd

nt4f04uNd commented May 12, 2023

Copy link
Copy Markdown
Member Author

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

Yeah, I wrote this in the issue. Should I make the CP request issue?

@auto-submit auto-submit Bot merged commit ae82f3c into flutter:master May 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
bcd082e 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
b6a054b 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
4b61e4b 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
228c58c 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
a466154 
…lutter#126539)
@nt4f04uNd nt4f04uNd mentioned this pull request May 14, 2023
Closed
@nt4f04uNd

nt4f04uNd commented May 14, 2023

Copy link
Copy Markdown
Member Author

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

Yeah, I wrote this in the issue. Should I make the CP request issue?

Filed #126782

@nt4f04uNd nt4f04uNd deleted the fix/126491/list-wheel-crash branch May 14, 2023 18:43
nt4f04uNd added a commit to nt4f04uNd/flutter that referenced this pull request May 15, 2023
@nt4f04uNd
Fix crash from invalid ListWheelViewport assertion (flutter#126539)
4cc6064 
Fixes flutter#126491
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
ed10c66 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
c60b8cf 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
67c812b 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
830ca00 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
16ec44d 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
21f536b 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
f78628e 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
7462f57 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
0e892a5 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
34f954d 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
8df4f96 
…lutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
e9531a4 
…lutter#126539)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@nt4f04uNd
Fix crash from invalid ListWheelViewport assertion (flutter#126539)
bf12d2b 
Fixes flutter#126491
@reidbaker reidbaker mentioned this pull request May 31, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
a927f61 
…lutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
06c0807 
…lutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
c6ae89b 
…lutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3c Fix crash from invalid ListWheelViewport assertion (flutter/f…
6cf9466 
…lutter#126539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: crash Stack traces logged to the console c: regression It was better in the past than it is now f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CupertinoPicker] Child paint transform happened to be null.

2 participants

@nt4f04uNd @Piinks