Skip to content

Update to valid build tools variant and update lockfiles #125825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 11 commits into from
Jul 17, 2023
Merged

Update to valid build tools variant and update lockfiles #125825

auto-submit merged 11 commits into from
Jul 17, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 1, 2023 •
edited
Loading

#125331

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 1, 2023
@reidbaker reidbaker changed the title Update to valid build tools variante and update lockfiles Update to valid build tools variant and update lockfiles May 1, 2023
@reidbaker reidbaker requested review from camsim99 and gmackall May 1, 2023 19:12
camsim99
camsim99 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) optional suggestion is modifying ci.yaml temporarily to verify you get a successful run

@reidbaker reidbaker changed the title Update to valid build tools variant and update lockfiles Revert changed that broke firebase_abstract_method_smoke_test May 8, 2023
@reidbaker reidbaker changed the title Revert changed that broke firebase_abstract_method_smoke_test Update to valid build tools variante and update lockfiles May 8, 2023
@reidbaker
Copy link
Contributor Author

reidbaker commented May 8, 2023

LGTM :) optional suggestion is modifying ci.yaml temporarily to verify you get a successful run

Good idea, Updated in 1b02013

@reidbaker
Copy link
Contributor Author

reidbaker commented May 8, 2023

Well damn https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8781629673726734545/+/u/test_execution/Build_appbundle/stdout

@reidbaker reidbaker marked this pull request as draft May 8, 2023 21:51
@reidbaker reidbaker changed the title Update to valid build tools variante and update lockfiles Update to valid build tools variant and update lockfiles May 8, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 8, 2023

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmackall gmackall mentioned this pull request May 11, 2023
Closed
@reidbaker reidbaker marked this pull request as ready for review July 14, 2023 17:06
@reidbaker reidbaker requested review from camsim99 and gmackall July 14, 2023 18:24
gmackall
gmackall approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again (looks like the web test timed out)

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
6a8baee 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
675ebbb 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
d4ac4be 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
e11b995 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
9eae81f 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
6224b0a 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
ced07c2 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
f61dbcc 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
227c6d6 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
08b9096 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
d6fe51f 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
f1b6a7c 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
954ab70 
…tter/flutter#125825)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
7a42ed7 Update to valid build tools variant and update lockfiles (flu…
6104919 
…tter/flutter#125825)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (#4518)
1127baf 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@f842ed9...6f09064

2023-07-17 goderbauer@google.com Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003)
2023-07-17 reidbaker@google.com Update to valid build tools variant and update lockfiles (flutter/flutter#125825)
2023-07-17 engine-flutter-autoroll@skia.org Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721)
2023-07-17 tessertaha@gmail.com [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711)
2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716)
2023-07-17 pavel.mazhnik@gmail.com [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513)
2023-07-17 tessertaha@gmail.com Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584)
2023-07-17 36861262+QuncCccccc@users.noreply.github.com Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464)
2023-07-17 ian@hixie.ch Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624)
2023-07-16 ian@hixie.ch Update list of CoC contacts. (flutter/flutter#130630)
2023-07-15 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@reidbaker @LouiseHsu
Update to valid build tools variant and update lockfiles (flutter#125825
b1098f4 
)

flutter#125331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @gmackall @camsim99