`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. #125643

QuncCccccc · 2023-04-27T17:43:55Z

See https://docs.flutter.dev/release/breaking-changes/checkbox-fillColor for a migration guide

Fixes #123386. The fillColor should always be applied to the background color based on its definition and the border color can be customized by Checkbox.side. When the checkbox is unselected, the default fillColor should be changed to transparent now, and we assign the original fillColor value to Checkbox.side.color. When the checkbox is selected, the default fillColor is same as the original value, and the Checkbox.side.color is transparent.

Checkbox(
  fillColor: MaterialStateProperty.resolveWith((Set<MaterialState> states) {
     if (states.contains(MaterialState.selected)) {
        return Colors.orange;
     }
     return Colors.green;
  }),
  value: false, // or true to show Colors.orange
  onChanged: (bool? value) { },
),

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

QuncCccccc · 2023-04-27T20:08:55Z

This will cause some scuba failures in g3. I will attach a g3fix cl/527658125 once this is merged.

HansMuller

Nice update. LGTM

HansMuller · 2023-04-27T23:26:25Z

packages/flutter/lib/src/material/checkbox.dart

So set activeSide(BorderSide value) { instead of this assert And the getter wouldn't need a !.

Got it. Fixing!

HansMuller · 2023-04-27T23:26:27Z

packages/flutter/lib/src/material/checkbox.dart

Same feedback as activeSide

…nd color when it is unchecked. (flutter/flutter#125643)

Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@66fa4c5...828a040 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 666bc34c61aa to 687f4c761db1 (2 revisions) (flutter/flutter#125818) 2023-05-01 34871572+gmackall@users.noreply.github.com Revert "Add migrator to upgrade gradle version when conflict with And… (flutter/flutter#125813) 2023-05-01 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125801) 2023-05-01 andrewrkolos@gmail.com [tools] fix `expect` calls in `FakeCommand` (flutter/flutter#125783) 2023-05-01 engine-flutter-autoroll@skia.org Roll Packages from 7e3f5da to de6131d (41 revisions) (flutter/flutter#125811) 2023-05-01 tessertaha@gmail.com Introduce `TabBar.tabAlignment` (flutter/flutter#125036) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0da68e7e024 to 666bc34c61aa (1 revision) (flutter/flutter#125805) 2023-05-01 44755140+werainkhatri@users.noreply.github.com add support to customize Slider interacivity (flutter/flutter#121483) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4551c72487c to b0da68e7e024 (1 revision) (flutter/flutter#125800) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 605528f293d0 to b4551c72487c (1 revision) (flutter/flutter#125795) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bba66b658cee to 605528f293d0 (2 revisions) (flutter/flutter#125793) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2fa61b91d7c2 to bba66b658cee (1 revision) (flutter/flutter#125791) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30c91b8180e7 to 2fa61b91d7c2 (1 revision) (flutter/flutter#125789) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from d76a22e67eea to 30c91b8180e7 (1 revision) (flutter/flutter#125787) 2023-05-01 andrewrkolos@gmail.com [tools] Apply Android Studio version detection logic to explicitly configured installation directory (`flutter config --android-studio-dir`) (flutter/flutter#125596) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) (flutter/flutter#125776) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) (flutter/flutter#125773) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) (flutter/flutter#125762) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1942b0c2cd9a to e99f31f4437d (1 revision) (flutter/flutter#125758) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7806f8a4fb4c to 1942b0c2cd9a (1 revision) (flutter/flutter#125757) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8167f909bc8d to 7806f8a4fb4c (2 revisions) (flutter/flutter#125750) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900b8a89b73b to 8167f909bc8d (1 revision) (flutter/flutter#125748) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c56ea398b0dc to 900b8a89b73b (1 revision) (flutter/flutter#125747) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) (flutter/flutter#125746) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) (flutter/flutter#125736) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (flutter/flutter#125735) 2023-04-29 dnfield@google.com Fix crasher in DragableScrollableSheet when controller is animating and switching widgets (flutter/flutter#125721) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (flutter/flutter#125734) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) (flutter/flutter#125731) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) (flutter/flutter#125729) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) (flutter/flutter#125725) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) (flutter/flutter#125722) 2023-04-29 65850618+Anas35@users.noreply.github.com fix package template create platform folders (flutter/flutter#125292) 2023-04-28 thkim1011@users.noreply.github.com Sliver Cross Axis Group (flutter/flutter#123862) 2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a84ea55e4ef to 1ae848ce6b55 (1 revision) (flutter/flutter#125718) 2023-04-28 zanderso@users.noreply.github.com Remove bringup from new_gallery_skia_ios__transition_perf (flutter/flutter#125715) 2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98b6fabc66bb to 2a84ea55e4ef (10 revisions) (flutter/flutter#125714) 2023-04-28 109111084+yaakovschectman@users.noreply.github.com Opt into CMake policy CMP0135 (flutter/flutter#125502) 2023-04-28 leroux_bruno@yahoo.fr Add a channel to query the engine keyboard state (flutter/flutter#122885) 2023-04-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125698) 2023-04-28 36861262+QuncCccccc@users.noreply.github.com `Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. (flutter/flutter#125643) 2023-04-28 zanderso@users.noreply.github.com Add back one Skia test on iOS (flutter/flutter#125663) 2023-04-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125447) 2023-04-28 97679004+phlippieb-discovery@users.noreply.github.com Nit: grammar in documentation (flutter/flutter#125462) ...

rydmike · 2023-07-10T16:39:01Z

@QuncCccccc This PR breaks ALL past previous CheckBox theming on stable 3.10 and earlier.

On stable 3.10.5 and earlier, one my customized Checkbox themes looks like this:

Note above the tinted disable state, which also uses a custom theme for enabled state at the same time.

Optionally it can look like this when we want the colored outline in none selected mode in stable 3.10.5 and earlier.

AFTER this PR the same theming produces these results:

And:

This is a SUPER breaking feature for past Checkbox theming behavior.

QuncCccccc · 2023-07-10T19:21:24Z

@QuncCccccc This PR breaks ALL past previous CheckBox theming on stable 3.10 and earlier.

On stable 3.10.5 and earlier, one my customized Checkbox themes looks like this: Note above the tinted disable state, which also uses a custom theme for enabled state at the same time.

Optionally it can look like this when we want the colored outline in none selected mode in stable 3.10.5 and earlier.

AFTER this PR the same theming produces these results:

And:

This is a SUPER breaking feature for past Checkbox theming behavior.

Hi! Sorry for causing that trouble! This PR is intended to fix the fillColor behavior error because based on its definition, it should be the background color of CheckBox. So some breaking behaviors are expected. Could you attach a code sample? I can help to take a look and fix it!

rydmike · 2023-07-10T20:02:24Z

@QuncCccccc, thanks and yes I do agree that the fillColor does behave oddly as it was (is in stable), but on the other hand stable channel code depends on that behavior.

I will open a separate regression issue with a sample. I was working on it, but got side tracked with a nice video call with @TahaTesser.

Issue coming soon, I will tag you and ref this PR. I just found this PR when I was tracking down why it was broken when I tested on master channel.

Sure I can use the new theme props and make it work, but potentially it is a breaking change for other users as well. I don't know if others have used this theming feature as much as I have, but potentially. This does need to be documented as BREAKING change if it remains as is, with migration docs. But let's see when I post the sample and we dig into it.

) Manual roll Flutter from 66fa4c5 to 828a040 (79 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@66fa4c5...828a040 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 666bc34c61aa to 687f4c761db1 (2 revisions) (flutter/flutter#125818) 2023-05-01 34871572+gmackall@users.noreply.github.com Revert "Add migrator to upgrade gradle version when conflict with And… (flutter/flutter#125813) 2023-05-01 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125801) 2023-05-01 andrewrkolos@gmail.com [tools] fix `expect` calls in `FakeCommand` (flutter/flutter#125783) 2023-05-01 engine-flutter-autoroll@skia.org Roll Packages from 7e3f5da to de6131d (41 revisions) (flutter/flutter#125811) 2023-05-01 tessertaha@gmail.com Introduce `TabBar.tabAlignment` (flutter/flutter#125036) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0da68e7e024 to 666bc34c61aa (1 revision) (flutter/flutter#125805) 2023-05-01 44755140+werainkhatri@users.noreply.github.com add support to customize Slider interacivity (flutter/flutter#121483) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4551c72487c to b0da68e7e024 (1 revision) (flutter/flutter#125800) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 605528f293d0 to b4551c72487c (1 revision) (flutter/flutter#125795) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bba66b658cee to 605528f293d0 (2 revisions) (flutter/flutter#125793) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2fa61b91d7c2 to bba66b658cee (1 revision) (flutter/flutter#125791) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30c91b8180e7 to 2fa61b91d7c2 (1 revision) (flutter/flutter#125789) 2023-05-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from d76a22e67eea to 30c91b8180e7 (1 revision) (flutter/flutter#125787) 2023-05-01 andrewrkolos@gmail.com [tools] Apply Android Studio version detection logic to explicitly configured installation directory (`flutter config --android-studio-dir`) (flutter/flutter#125596) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) (flutter/flutter#125776) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) (flutter/flutter#125773) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) (flutter/flutter#125762) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1942b0c2cd9a to e99f31f4437d (1 revision) (flutter/flutter#125758) 2023-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7806f8a4fb4c to 1942b0c2cd9a (1 revision) (flutter/flutter#125757) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8167f909bc8d to 7806f8a4fb4c (2 revisions) (flutter/flutter#125750) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 900b8a89b73b to 8167f909bc8d (1 revision) (flutter/flutter#125748) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c56ea398b0dc to 900b8a89b73b (1 revision) (flutter/flutter#125747) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) (flutter/flutter#125746) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) (flutter/flutter#125736) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (flutter/flutter#125735) 2023-04-29 dnfield@google.com Fix crasher in DragableScrollableSheet when controller is animating and switching widgets (flutter/flutter#125721) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (flutter/flutter#125734) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) (flutter/flutter#125731) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) (flutter/flutter#125729) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) (flutter/flutter#125725) 2023-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) (flutter/flutter#125722) 2023-04-29 65850618+Anas35@users.noreply.github.com fix package template create platform folders (flutter/flutter#125292) 2023-04-28 thkim1011@users.noreply.github.com Sliver Cross Axis Group (flutter/flutter#123862) 2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a84ea55e4ef to 1ae848ce6b55 (1 revision) (flutter/flutter#125718) 2023-04-28 zanderso@users.noreply.github.com Remove bringup from new_gallery_skia_ios__transition_perf (flutter/flutter#125715) 2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98b6fabc66bb to 2a84ea55e4ef (10 revisions) (flutter/flutter#125714) 2023-04-28 109111084+yaakovschectman@users.noreply.github.com Opt into CMake policy CMP0135 (flutter/flutter#125502) 2023-04-28 leroux_bruno@yahoo.fr Add a channel to query the engine keyboard state (flutter/flutter#122885) 2023-04-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125698) 2023-04-28 36861262+QuncCccccc@users.noreply.github.com `Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. (flutter/flutter#125643) 2023-04-28 zanderso@users.noreply.github.com Add back one Skia test on iOS (flutter/flutter#125663) 2023-04-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125447) 2023-04-28 97679004+phlippieb-discovery@users.noreply.github.com Nit: grammar in documentation (flutter/flutter#125462) ...

Migration guide for flutter/flutter#125643 Fixes flutter/flutter#130295

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 27, 2023

QuncCccccc force-pushed the add_inactive_background_color_for_checkbox branch from 3d64414 to 7582725 Compare April 27, 2023 17:45

QuncCccccc marked this pull request as ready for review April 27, 2023 19:53

QuncCccccc requested a review from HansMuller April 27, 2023 19:53

HansMuller approved these changes Apr 27, 2023

View reviewed changes

QuncCccccc added 7 commits April 28, 2023 09:58

Update checkbox defaults

fd63fbb

Update token template

763746f

Update unit tests

99b8902

Update unit test

f6d0416

Update checkbox theme unit tests

6200695

Update Checkbox.adaptive doc

85a070d

Update parameter type and remove unnecessary assert

471fc10

QuncCccccc force-pushed the add_inactive_background_color_for_checkbox branch from 3c28dfb to 471fc10 Compare April 28, 2023 16:59

QuncCccccc merged commit a433f88 into flutter:master Apr 28, 2023

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 14981ffc0222 (55 revisions) flutter/packages#3852

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

66f109e

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 14981ffc0222 (55 revisions) flutter/packages#3853

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

dbdb13f

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 807c55c6b322 (56 revisions) flutter/packages#3854

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

1f9686b

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 29b3e66ecbea (57 revisions) flutter/packages#3855

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

0201002

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request Apr 30, 2023

Roll Flutter from 66fa4c5d301c to 9241329b4669 (62 revisions) flutter/packages#3856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

6320274

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request Apr 30, 2023

Roll Flutter from 66fa4c5d301c to 9241329b4669 (62 revisions) flutter/packages#3857

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

978e493

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Flutter from 66fa4c5d301c to d9ea36ccb7a8 (71 revisions) flutter/packages#3863

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

bda976f

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Flutter from 66fa4c5d301c to 293715a6a40f (72 revisions) flutter/packages#3864

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

7b6d128

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Flutter from 66fa4c5d301c to a732a7488807 (74 revisions) flutter/packages#3865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

7df85f6

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Flutter from 66fa4c5d301c to ff248d2346ff (75 revisions) flutter/packages#3866

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

6f7f2ad

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Flutter from 66fa4c5d301c to b2f22321329f (77 revisions) flutter/packages#3867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

c3c7839

…nd color when it is unchecked. (flutter/flutter#125643)

This was referenced May 1, 2023

Manual roll Flutter from 66fa4c5d301c to db7196c52cf8 (78 revisions) flutter/packages#3869

Closed

Roll Flutter from 66fa4c5d301c to db7196c52cf8 (78 revisions) flutter/packages#3870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

a2dd5fd

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

885c0de

…nd color when it is unchecked. (flutter/flutter#125643)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Manual roll Flutter from 66fa4c5d301c to 828a04040e11 (79 revisions) flutter/packages#3874

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

a433f88 Checkbox.fillColor should be applied to checkbox's backgrou…

9d4ddc0

…nd color when it is unchecked. (flutter/flutter#125643)

HansMuller mentioned this pull request May 5, 2023

Flutter Framework Team: Notable Commits #121415

Closed

rydmike mentioned this pull request Jul 10, 2023

Document Checkbox.fillColor behavior change #130295

Closed

2 tasks

rydmike mentioned this pull request Aug 16, 2023

Version 7-3-0 rydmike/flex_color_scheme#180

Merged

TahaTesser mentioned this pull request Aug 22, 2023

[breaking-change] Updated Checkbox.fillColor behavior flutter/website#9279

Merged

3 tasks

parlough pushed a commit to flutter/website that referenced this pull request Aug 22, 2023

[breaking-change] Updated Checkbox.fillColor behavior (#9279)

224bdc9

Migration guide for flutter/flutter#125643 Fixes flutter/flutter#130295

Piinks mentioned this pull request Jan 29, 2024

[ios]: fillColor for Checkbox.adaptive is ignored #134917

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. #125643

`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. #125643

Uh oh!

QuncCccccc commented Apr 27, 2023 •

edited by TahaTesser

Loading

Uh oh!

QuncCccccc commented Apr 27, 2023

Uh oh!

HansMuller left a comment

Uh oh!

HansMuller Apr 27, 2023

Uh oh!

QuncCccccc Apr 27, 2023

Uh oh!

HansMuller Apr 27, 2023

Uh oh!

rydmike commented Jul 10, 2023

Uh oh!

QuncCccccc commented Jul 10, 2023

Uh oh!

rydmike commented Jul 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Checkbox.fillColor should be applied to checkbox's background color when it is unchecked. #125643

Checkbox.fillColor should be applied to checkbox's background color when it is unchecked. #125643

Uh oh!

Conversation

QuncCccccc commented Apr 27, 2023 • edited by TahaTesser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

QuncCccccc commented Apr 27, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

rydmike commented Jul 10, 2023

Uh oh!

QuncCccccc commented Jul 10, 2023

Uh oh!

rydmike commented Jul 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. #125643

`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. #125643

QuncCccccc commented Apr 27, 2023 •

edited by TahaTesser

Loading