Skip to content

Cleans up appbar imply leading logic #125315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 4, 2023
Merged

Cleans up appbar imply leading logic #125315

auto-submit merged 1 commit into from
May 4, 2023

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 21, 2023

fixes #80256

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2023
@chunhtai chunhtai requested a review from dnfield April 21, 2023 22:06
goderbauer
goderbauer approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai force-pushed the issues/80256-migrate branch from aeb0a8a to 3fd2da4 Compare May 3, 2023 18:18
@chunhtai chunhtai force-pushed the issues/80256-migrate branch from 3fd2da4 to 8351952 Compare May 4, 2023 17:20
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023
@auto-submit auto-submit bot merged commit 0b65723 into flutter:master May 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
0b65723 Cleans up appbar imply leading logic (flutter/flutter#125315)
2e2d095
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
0b65723 Cleans up appbar imply leading logic (flutter/flutter#125315)
9f0869f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0b65723 Cleans up appbar imply leading logic (flutter/flutter#125315)
aa9f5df
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0b65723 Cleans up appbar imply leading logic (flutter/flutter#125315)
a147d80
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0b65723 Cleans up appbar imply leading logic (flutter/flutter#125315)
e2b218b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BackButton is not displayed when there is a endDrawer

2 participants

@chunhtai @goderbauer