Skip to content

Sliver Constrained Cross Axis #125239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Apr 24, 2023
Merged

Sliver Constrained Cross Axis #125239

auto-submit merged 7 commits into from
Apr 24, 2023

Conversation

@thkim1011
Copy link
Contributor

@thkim1011 thkim1011 commented Apr 20, 2023

Reimplements what we reverted here: #125233.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 20, 2023
@thkim1011 thkim1011 requested a review from Piinks April 20, 2023 19:13
Piinks
Piinks reviewed Apr 20, 2023
View reviewed changes
packages/flutter/lib/src/widgets/sliver.dart
}

@override
Type get debugTypicalAncestorWidgetClass => Widget;
Copy link
Contributor

@Piinks Piinks Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this Widget? Usually this is a bit more specific, can you explain?

Copy link
Contributor Author

@thkim1011 thkim1011 Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SliverCrossAxisGroup has yet to be defined, but I will change it in the SliverCrossAxisGroup PR.

thkim1011 and others added 4 commits April 20, 2023 16:42
@thkim1011 @Piinks
Update packages/flutter/lib/src/rendering/sliver.dart
aa7ae83 
Co-authored-by: Kate Lovett <katelovett@google.com>
@thkim1011 @Piinks
Update packages/flutter/lib/src/rendering/sliver.dart
eb1fd6c 
Co-authored-by: Kate Lovett <katelovett@google.com>
@thkim1011
address comments
b16792e
@thkim1011 @Piinks
Update packages/flutter/lib/src/widgets/sliver.dart
ba50966 
Co-authored-by: Kate Lovett <katelovett@google.com>
@thkim1011 thkim1011 requested a review from Piinks April 20, 2023 21:13
Piinks
Piinks reviewed Apr 24, 2023
View reviewed changes
packages/flutter/lib/src/rendering/sliver.dart
Comment on lines +1007 to +1008
/// If null or zero, the child is inflexible and determines its own size in the cross axis.
int? crossAxisFlex;
Copy link
Contributor

@Piinks Piinks Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this with the SliverGroup? I think I recall there was an issue with wanting to flex normal slivers along with SliverCross..Expanded. How will the group determine that a normal sliver, say SliverList, should flex if it's flex value is null?

Copy link
Contributor

@Piinks Piinks Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only item left here to resolve. :)

Copy link
Contributor Author

@thkim1011 thkim1011 Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I've tried this with SliverGroup and it works well. Essentially SliverGroup's setupParentData method will create children parentData with crossAxisFlex of 1. However, the ParentDataWidgets for the SliverCrossAxisConstrained will set this to 0, for the constrained widgets.

Piinks
Piinks approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023
@auto-submit auto-submit bot merged commit 482d1aa into flutter:master Apr 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
7826e5e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
295978d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
4483780
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
70b5ae8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
ff27eb7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
482d1aa Sliver Constrained Cross Axis (flutter/flutter#125239)
67d7149
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (#3830)
66703bc 
Roll Flutter from c9004ff to 66fa4c5 (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 zanderso@users.noreply.github.com Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 goderbauer@google.com Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 jmccandless@google.com iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 magder@google.com Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 54558023+keyonghan@users.noreply.github.com Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 magder@google.com Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
@HansMuller HansMuller mentioned this pull request Apr 28, 2023
Closed
@Piinks Piinks mentioned this pull request May 2, 2023
Open
2 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter#3830)
8844fd8 
Roll Flutter from c9004ff to 66fa4c5 (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 zanderso@users.noreply.github.com Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 goderbauer@google.com Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 jmccandless@google.com iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 magder@google.com Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 54558023+keyonghan@users.noreply.github.com Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 magder@google.com Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thkim1011 @Piinks