Skip to content

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Apr 12, 2023

issue #123378

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 12, 2023
@flutter flutter deleted a comment from flutter-dashboard bot Apr 14, 2023
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Apr 14, 2023
@hannah-hyj hannah-hyj requested a review from chunhtai April 15, 2023 00:00
hannah-hyj and others added 2 commits April 17, 2023 11:32
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
@hannah-hyj hannah-hyj requested a review from chunhtai April 17, 2023 18:32
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023
@auto-submit auto-submit bot merged commit 2f45458 into flutter:master Apr 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 18, 2023
Manual roll requested by ychris@google.com

flutter/flutter@50171bb...15cb1f8

2023-04-17 tessertaha@gmail.com Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673)
2023-04-17 47866232+chunhtai@users.noreply.github.com Deprecates string for reorderable list in material_localizations (flutter/flutter#124711)
2023-04-17 jhy03261997@gmail.com Fix a null crash in SelectableRegion Widget  (flutter/flutter#124736)
2023-04-17 54718862+mub-pro@users.noreply.github.com Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987)
2023-04-17 godofredoc@google.com Remove token permissions for coverage. (flutter/flutter#124909)
2023-04-17 engine-flutter-autoroll@skia.org Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
8 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
Manual roll requested by ychris@google.com

flutter/flutter@50171bb...15cb1f8

2023-04-17 tessertaha@gmail.com Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673)
2023-04-17 47866232+chunhtai@users.noreply.github.com Deprecates string for reorderable list in material_localizations (flutter/flutter#124711)
2023-04-17 jhy03261997@gmail.com Fix a null crash in SelectableRegion Widget  (flutter/flutter#124736)
2023-04-17 54718862+mub-pro@users.noreply.github.com Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987)
2023-04-17 godofredoc@google.com Remove token permissions for coverage. (flutter/flutter#124909)
2023-04-17 engine-flutter-autoroll@skia.org Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963)
2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants