SelectionContainer's listeners can remove itself during listener call… #124624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Apr 11, 2023
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM, but there are test failures. Not sure if they have to do with this or not.
Contributor
|
auto label is removed for flutter/flutter, pr: 124624, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
waiting CL to land cl/524029250 |
Contributor
|
auto label is removed for flutter/flutter, pr: 124624, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 18, 2023
flutter/flutter@15cb1f8...42fb0b2 2023-04-18 katelovett@google.com Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 gspencergoog@users.noreply.github.com Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 jmccandless@google.com Remove unused context parameter (flutter/flutter#124254) 2023-04-18 jmccandless@google.com iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 zanderso@users.noreply.github.com Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 engine-flutter-autoroll@skia.org Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125005) 2023-04-18 pateltirth454@gmail.com [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 44755140+werainkhatri@users.noreply.github.com relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 katelovett@google.com Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 barpac02@gmail.com Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 warriorharish95668@gmail.com Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 36861262+QuncCccccc@users.noreply.github.com Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 47866232+chunhtai@users.noreply.github.com SelectionContainer's listeners can remove itself during listener call� (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
…125140) The regression was caused by the previous pr #124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run. After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt. Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback. fixes #125065
This was referenced Apr 20, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@15cb1f8...42fb0b2 2023-04-18 katelovett@google.com Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 gspencergoog@users.noreply.github.com Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 jmccandless@google.com Remove unused context parameter (flutter/flutter#124254) 2023-04-18 jmccandless@google.com iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 zanderso@users.noreply.github.com Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 engine-flutter-autoroll@skia.org Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125005) 2023-04-18 pateltirth454@gmail.com [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 44755140+werainkhatri@users.noreply.github.com relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 katelovett@google.com Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 barpac02@gmail.com Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 warriorharish95668@gmail.com Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 36861262+QuncCccccc@users.noreply.github.com Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 47866232+chunhtai@users.noreply.github.com SelectionContainer's listeners can remove itself during listener call� (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swapping out delegate of selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.