Skip to content

Conversation

@Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Apr 7, 2023

Reland of #123726 fixing the issues mentioned here #124401

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 7, 2023
@Rexios80
Copy link
Member Author

Rexios80 commented Apr 7, 2023

Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rexios80
Copy link
Member Author

@goderbauer Do you need to add the autosubmit label again?

@Rexios80
Copy link
Member Author

In case anyone wants to use this code before it's released to stable, I copied this code into the mock_event_channel package. When this PR is released to stable, just remove that package.

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
[flutter_test] Adds method to mock EventChannels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants