Adds dart_fix support to flutter_test
#124347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Apr 6, 2023
Member
goderbauer
left a comment
There was a problem hiding this comment.
Some fly-by comment. I am so excited to have this! Also, thank you soo much for adding all these fixes for existing deprecated properties!
packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml
Outdated
Show resolved
Hide resolved
...st/lib/fix_data/fix_flutter_test/fix_binding/fix_automated_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
packages/flutter_test/test_fixes/flutter_test/animation_sheet_builder.dart
Outdated
Show resolved
Hide resolved
...ges/flutter_test/test_fixes/flutter_test/binding/automated_test_widgets_flutter_binding.dart
Outdated
Show resolved
Hide resolved
Piinks
reviewed
Apr 6, 2023
Contributor
Piinks
left a comment
There was a problem hiding this comment.
This is AWESOME! Thank you! 🎉
packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml
Outdated
Show resolved
Hide resolved
packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml
Outdated
Show resolved
Hide resolved
packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml
Outdated
Show resolved
Hide resolved
...er_test/lib/fix_data/fix_flutter_test/fix_binding/fix_live_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
...flutter_test/lib/fix_data/fix_flutter_test/fix_binding/fix_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
...flutter_test/lib/fix_data/fix_flutter_test/fix_binding/fix_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
packages/flutter_test/test_fixes/flutter_test/animation_sheet_builder.dart
Outdated
Show resolved
Hide resolved
...ges/flutter_test/test_fixes/flutter_test/binding/automated_test_widgets_flutter_binding.dart
Outdated
Show resolved
Hide resolved
Contributor
|
LOL I am too slow for @goderbauer |
goderbauer
reviewed
Apr 6, 2023
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Deferring to @Piinks for final approval!
packages/flutter_test/test_fixes/flutter_test/binding/test_widgets_flutter_binding.dart
Outdated
Show resolved
Hide resolved
* Adds fixes for the first round of deprecations listed in flutter#122323 * Adds tests for all new fixes * Adds a note for the `runTest(timeout)` deprecations to prevent them from being removed before `integration_test` also has `dart fix` support
* Fixed typos in README.md * Updated examples in `flutter_test`'s README.md to relate better to `flutter_test`'s codebase * Updated various fix titles * Simplified some of the fix tests * Added "Changes added" comments to lines in fix tests * Added missing newlines for ends of files
c1dce60 to
7d242f1
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Adds `dart_fix` support to `flutter_test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runTest(timeout)deprecations to prevent them from being removed beforeintegration_testalso hasdart fixsupportResolves #123154
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].