Sliver Constrained Cross Axis #124337
Merged
Sliver Constrained Cross Axis #124337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
reviewed
Apr 6, 2023
Piinks
reviewed
Apr 7, 2023
examples/api/lib/widgets/sliver/sliver_constrained_cross_axis.0.dart
Outdated
Show resolved
Hide resolved
Piinks
reviewed
Apr 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2023
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
Sliver Constrained Cross Axis
thkim1011
added a commit
that referenced
this pull request
Apr 20, 2023
This reverts commit 3c18f57.
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
Going to make some changes to the implementation so I'll revert in the meantime. Reverts #124337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new Sliver that constrains the child sliver's cross axis extent.
Eventually, we'll also add a
flexvalue toSliverPhysicalParentDatawhich must be explicitly set to 0 by this widget in order to override theSliverCrossAxisGroup's default behavior to make slivers expand.This is prerequisite work for #123862.
Fixes #120896