Add support to the flutter tool to compile against the skwasm renderer #124296
Conversation
| canvaskit, | ||
| /// Always uses html. | ||
| html, | ||
| /// Always use skwasm. |
There was a problem hiding this comment.
nit: the above options say "uses"
| resolve({ | ||
| "skwasm": skwasmInstance.asm, | ||
| "ffi": { | ||
| "memory": skwasmInstance.wasmMemory, |
There was a problem hiding this comment.
nit: use single-quote for consistency
| serviceWorkerStrategy: kNoneWorker, | ||
| sourceMaps: true, | ||
| nativeNullAssertions:debuggingOptions.nativeNullAssertions, | ||
| isWasm: false, |
There was a problem hiding this comment.
Nice! We crossed the threshold of the reasonable number of positional arguments a while ago.
There was a problem hiding this comment.
I think this is the change that actually conflicts with Kevin's change, so I'm probably going to go with his changes because they are a little more flexible.
| moduleInstance = await dart2wasm_runtime.instantiate(dartModulePromise, imports); | ||
| } catch (exception) { | ||
| console.error(`Failed to fetch and instantiate wasm module: ${exception}`); | ||
| console.error(`Failed to fetch and instantiate wasm module: \${exception}`); |
There was a problem hiding this comment.
Wow, how did this compile before? I don't see a variable named exception in scope 🤔
There was a problem hiding this comment.
In this PR, we changed this from a raw string literal (i.e. r''') to a multi-line string literal (i.e. ''') so we didn't need to escape before. We are doing string interpolation depending on whether you are going to actually import skwasm or not, so we needed to switch away from the raw string literal and escape any $ in the document.
|
I broke you. But I think you'll like where we end up! |
flutter#124296) Add support to the flutter tool to compile against the skwasm renderer
This allows the flutter tool to compile against the skwasm renderer, and changes our bootstrapping code to link the skwasm module. The resulting application doesn't actually work yet, but this sets us up to further iterate as more skwasm APIs are implemented.