Skip to content

Make logs verbose for gallery tests #124271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 7, 2023
Merged

Make logs verbose for gallery tests #124271

auto-submit merged 2 commits into from
Apr 7, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Apr 5, 2023 •
edited
Loading

Making tests verbose to help debug this issue: #124219

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 5, 2023
@vashworth vashworth requested a review from jmagman April 5, 2023 21:09
@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit auto-submit bot merged commit c52042f into flutter:master Apr 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2023
@engine-flutter-autoroll
c52042f Make logs verbose for gallery tests (flutter/flutter#124271)
25b0298
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@vashworth @exaby73
Make logs verbose for gallery tests (flutter#124271)
2c5671b 
Make logs verbose for gallery tests
vashworth added a commit to vashworth/flutter that referenced this pull request Jun 14, 2023
@vashworth
Revert "Make logs verbose for gallery tests (flutter#124271)"
d0e070f 
This reverts commit c52042f.
@vashworth vashworth deleted the make_test_verbose branch September 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @jmagman