Skip to content

[Impeller] Plumb through the impeller-force-gl flag. #123828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 31, 2023
Merged

[Impeller] Plumb through the impeller-force-gl flag. #123828

auto-submit merged 1 commit into from
Mar 31, 2023

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Mar 30, 2023

Sibling of the engine patch flutter/engine#40809
Part of #116801

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 30, 2023
@chinmaygarde chinmaygarde mentioned this pull request Mar 30, 2023
Merged
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@chinmaygarde chinmaygarde self-assigned this Mar 31, 2023
@chinmaygarde chinmaygarde added the e: impeller Impeller rendering backend issues and features requests label Mar 31, 2023
@auto-submit auto-submit bot merged commit f6c2b10 into flutter:master Mar 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
600918f 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
7abb09f 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
8d21dbf 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
30e62a4 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
67d525d 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
763cf77 
…/flutter#123828)
@chinmaygarde chinmaygarde deleted the forcegl branch March 31, 2023 20:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
78195f3 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
aed3a5c 
…/flutter#123828)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
1f3e891 
…/flutter#123828)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@chinmaygarde @exaby73
[Impeller] Plumb through the impeller-force-gl flag. (flutter#123828)
4ca64af 
[Impeller] Plumb through the impeller-force-gl flag.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
4aa6453 
…/flutter#123828)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f6c2b10 [Impeller] Plumb through the impeller-force-gl flag. (flutter…
f69bbfe 
…/flutter#123828)
dnfield added a commit that referenced this pull request Dec 22, 2023
@dnfield
Revert "[Impeller] Plumb through the impeller-force-gl flag. (#123828)"
1a50b30 
This reverts commit f6c2b10.
@dnfield dnfield mentioned this pull request Dec 22, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jan 2, 2024
@dnfield
Revert "[Impeller] Plumb through the impeller-force-gl flag." (#140535)
bfdc32f 
Reverts #123828

Fixes #140523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chinmaygarde chinmaygarde

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller Impeller rendering backend issues and features requests tool Affects the "flutter" command-line tool. See also t: labels.

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chinmaygarde @dnfield