Skip to content

Conversation

@whiskeyPeak
Copy link
Contributor

@whiskeyPeak whiskeyPeak commented Mar 28, 2023

Wires up the clipBehaviour property for the MenuAnchor widget. The default clip is Clip.hard as it was before, only now modifying this value actually leads to visual changes.

simplescreenrecorder-2023-03-28_20.06.46.mp4

@gspencergoog I'm not really sure how to test this... Any thoughts?

Fixes #123628

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 28, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@whiskeyPeak
Copy link
Contributor Author

Checking the value of clipBehaviour wouldn't really test anything since the change in state is further down the tree and an entire golden test for this small bug fix seems a little excessive IMO

@whiskeyPeak
Copy link
Contributor Author

I had to change an existing test because the "default" value for the SubMenuButton widget changed from Clip.none to Clip.hardEdge. However, since the original default value was never used in the widget tree and a hardcoded value of Clip.hardEdge was used instead, there is no change in functionality. I hope this is ok? :)

@TahaTesser
Copy link
Member

@gspencergoog I'm not really sure how to test this... Any thoughts?

This requires a test in order to land. You can get the material from _MenuPanel and check its clip behavior (you can find similar test in the framework)

@whiskeyPeak
Copy link
Contributor Author

@TahaTesser Ok, added a test to check the default clip of a ManuAnchor widget. PTAL!

@whiskeyPeak

This comment was marked as resolved.

@whiskeyPeak
Copy link
Contributor Author

@TahaTesser I think this is what you meant? :)

@TahaTesser
Copy link
Member

TahaTesser commented Mar 30, 2023

We need a second review from @gspencergoog to land this.

Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for catching (and fixing!) that.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit 5f71179 into flutter:master Mar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
Wire up MenuAnchor clipBehaviour property
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MenuAnchor clipBehaviour property isn't wired up to the widget

3 participants