-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Wire up MenuAnchor clipBehaviour property #123632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up MenuAnchor clipBehaviour property #123632
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Checking the value of |
|
I had to change an existing test because the "default" value for the |
This requires a test in order to land. You can get the material from |
|
@TahaTesser Ok, added a test to check the default clip of a ManuAnchor widget. PTAL! |
This comment was marked as resolved.
This comment was marked as resolved.
|
@TahaTesser I think this is what you meant? :) |
|
We need a second review from @gspencergoog to land this. |
TahaTesser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wire up MenuAnchor clipBehaviour property

Wires up the
clipBehaviourproperty for the MenuAnchor widget. The default clip is Clip.hard as it was before, only now modifying this value actually leads to visual changes.simplescreenrecorder-2023-03-28_20.06.46.mp4
@gspencergoog I'm not really sure how to test this... Any thoughts?
Fixes #123628